[JA DateTimeV2] Merged refinements #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellarin
reviewed
May 14, 2022
| swiftDay++; | ||
| } | ||
|
|
||
| var pastDate1 = pastDate.AddDays(swiftDay); |
There was a problem hiding this comment.
Maybe rename to pastDateAlt as it's an alternative resolution?
tellarin
requested changes
May 14, 2022
| var start = timex.IndexOf(Constants.TimeTimexPrefix) + 1; | ||
| var end = timex.IndexOf(Constants.TimeTimexConnector); | ||
| end = end > 0 ? end : timex.Length; | ||
| var hourStr = timex.Substring(start, end - start); |
There was a problem hiding this comment.
From now on, let's try to write such functions using Spans, to avoid creating a lot of small string objects garbage collected all the time. Please open an issue to refactor existing Timex parsing code to do the same.
There was a problem hiding this comment.
@aitelint Please ACK this comment. Thanks.
There was a problem hiding this comment.
@tellarin, issue created
There was a problem hiding this comment.
@tellarin, the problem is that net462 does not support parsing of spans, so we would need to convert the span back to string when passing it to int.TryParse
| public static Tuple<int, int> ParseHoursFromTimePeriodTimex(string timex) | ||
| { | ||
| int hour1 = 0, hour2 = 0; | ||
| var timeList = timex.Split(Constants.TimexSeparator[0]); |
tellarin
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All test cases pass.
Added support for the 30-hour clock form (commonly used in Japanese) and relative test cases in DateTimeParser, DateTimePeriodParser, MergedParser, TimeParser and TimePeriodParser.
Modified test cases:
In DateParser:
In MergedExtractor: