Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZH DateTimeV2] Handling of modifiers "since" and "until" in Chinese is inconsistent with English implementation #2557

Closed
aitelint opened this issue Apr 15, 2021 · 0 comments

Comments

@aitelint
Copy link
Contributor

aitelint commented Apr 15, 2021

Describe the bug

  • In standard English implementation, the modifiers "after" and "since" convert the "value" key to "start" and the modifiers "before" and "until" convert the "value" key to "end".
  • In Chinese implementation, only the modifiers "after" and "before" modify the "value" key while "since" and "until" keep it unchanged.

To Reproduce
For example, the input "在2012年1月7日或之前" (On or before January 7) in Chinese is resolved to
{
"timex": "2012-01-07",
"Mod": "until",
"type": "daterange",
"sourceEntity": "datetimepoint",
"value": "2012-01-07"
}
while in English is resolved to
{
"timex": "2012-01-07",
"Mod": "until",
"type": "daterange",
"sourceEntity": "datetimepoint",
"end": "2012-01-07"
}

Expected behavior
The Chinese implementation should behave as the English one and modify the "value" key also with modifiers "since" and "until".

aitelint pushed a commit to aitelint/Recognizers-Text that referenced this issue May 13, 2021
aitelint pushed a commit to aitelint/Recognizers-Text that referenced this issue Dec 7, 2021
tellarin pushed a commit that referenced this issue Apr 29, 2022
…K implementation (#2557) (#2593)

Co-authored-by: LionbridgeCS2 <[email protected]>
Co-authored-by: aitelint <[email protected]>
aitelint pushed a commit to aitelint/Recognizers-Text that referenced this issue Jun 4, 2022
tellarin pushed a commit that referenced this issue Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants