-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling automation of experiments running v1.0 #469
base: main
Are you sure you want to change the base?
Conversation
@xisen-w please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
b44bef5
to
21a99d2
Compare
@@ -0,0 +1,5 @@ | |||
if_using_vector_rag=False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the environment should capitalized.
@@ -0,0 +1,8 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you submit this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought since this was not to be merged I could show how the json is organised for now.
I will hide it in the next commit.
@@ -0,0 +1,136 @@ | |||
#!/bin/bash | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file for?
@@ -117,6 +117,7 @@ venv/ | |||
ENV/ | |||
env.bak/ | |||
venv.bak/ | |||
.huaxia_env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this for? is it necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! Was about to hide this.
Description
This PR revises the automation of experiment runs in the
eval.sh
script. It addresses issues related to the configuration and execution of experiments, ensuring that the correct environment variables are set and that the script runs smoothly without manual intervention.Motivation and Context
This change is required to streamline the process of running experiments, reducing manual setup and potential errors. It solves the problem of inconsistent experiment configurations and enhances the automation capabilities of the system.
How Has This Been Tested?
eval.sh
script runs without errors and correctly sets up the environment for experiments.Screenshots of Test Results (if appropriate):
Types of changes
📚 Documentation preview 📚: https://RDAgent--469.org.readthedocs.build/en/469/