Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements cleanup #867

Merged
merged 4 commits into from
Nov 13, 2017

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Nov 13, 2017

Fixes #863 #750 and bumps numpy and pyqt/sip to latest bug fix releases @QCoDeS/core

requirements.txt Outdated
matplotlib==2.0.2
pyqtgraph==0.10.0
PyVISA==1.8
PyQt5==5.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis can't install this. Does that not mean that our CI will stop working?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know its because that version is only out for win and OSx not linux. I have reverted this

Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@jenshnielsen jenshnielsen merged commit 5979336 into microsoft:master Nov 13, 2017
@jenshnielsen jenshnielsen deleted the requirements_cleanup branch November 13, 2017 12:22
giulioungaretti pushed a commit that referenced this pull request Nov 13, 2017
Author: Jens Hedegaard Nielsen <[email protected]>

    Requirements cleanup (#867)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing dependencyjsonschema in requirements.txt
2 participants