make print_readable_snapshot work with value-less parameters #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
reviewed
Nov 2, 2017
qcodes/instrument/base.py
Outdated
| @@ -227,7 +227,14 @@ def print_readable_snapshot(self, update=False, max_chars=80): | |||
| for par in sorted(snapshot['parameters']): | |||
| name = snapshot['parameters'][par]['name'] | |||
| msg = '{0:<{1}}:'.format(name, par_field_len) | |||
| val = snapshot['parameters'][par]['value'] | |||
|
|
|||
| # in case of e.g. ArrayParameters, the parameter may not have | |||
There was a problem hiding this comment.
I would change the docstring to say in case snapshot_value is False otherwise 👍
There was a problem hiding this comment.
Perhaps a slight preference for snapshot['parameters'][par].get('value', 'Not available') in stead of try except
There was a problem hiding this comment.
I wholeheartedly agree with your viewpoint.
jenshnielsen
approved these changes
Nov 2, 2017
giulioungaretti
pushed a commit
that referenced
this pull request
Nov 2, 2017
Author: William H.P. Nielsen <[email protected]> make print_readable_snapshot work with value-less parameters (#844)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a parameter does not have a value in the snapshot (e.g. because it is an ArrayParameter), the
print_readable_snapshotfunction can not iterate through all parameters and values. This PR fixes that.Changes proposed in this pull request:
print_readable_snapshothandle missing values@jenshnielsen @AdriaanRol