add debugging and make the final write more robust #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +11,8 @@ | |||
| from .location import FormatLocation | |||
| from qcodes.utils.helpers import DelegateAttributes, full_class, deep_update | |||
|
|
|||
There was a problem hiding this comment.
There is a bunch of old style non named loggers in this file. I think we should convert those too
|
Looks good 👍 for a test based on #821 Does finalise get called if you keyboard interrupt ? |
qcodes/tests/test_loop.py
Outdated
| super().__init__(name=name, names=names, shapes=shapes, | ||
| instrument=instrument) | ||
|
|
||
| def get(self): # this results in a nan-filled DataArray |
There was a problem hiding this comment.
might as well make this get_raw to not get the warning?
|
The abstract write method in |
jenshnielsen
approved these changes
Oct 27, 2017
giulioungaretti
pushed a commit
that referenced
this pull request
Oct 27, 2017
Author: William H.P. Nielsen <[email protected]> add debugging and make the final write more robust (#822)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #821
Changes proposed in this pull request:
log.debugto the data saving processqc.Loop's final writing of data more robust@jenshnielsen @sohailc