Pyqtgraph automatically store ref to the last 100 plots (configurable) #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamHPNielsen
approved these changes
Jun 30, 2017
giulioungaretti
pushed a commit
that referenced
this pull request
Jul 3, 2017
Author: Jens Hedegaard Nielsen <[email protected]> Pyqtgraph automatically store ref to the last 100 plots (configurable) (#662)
Dominik-Vogel
pushed a commit
to Dominik-Vogel/Qcodes
that referenced
this pull request
Aug 9, 2017
microsoft#662) * Protect against crashed qt remote processes * WIP trying to store refs to plots * Store last 100 qt plots in a deque * make max num plots a configurable
peendebak
pushed a commit
to VandersypenQutech/Qcodes
that referenced
this pull request
Aug 11, 2017
microsoft#662) * Protect against crashed qt remote processes * WIP trying to store refs to plots * Store last 100 qt plots in a deque * make max num plots a configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #647
Currently pyqt graph plots may close spontaneously if you don't keep a reference to the plot around. This creates a deque as a Class parameter in QtPlot that automatically keeps the last n (default 100) plots in reference. The number of plots to keep can be configured. In my tests 100 plots of a (100,100) heatmap is roughly 1 GB of memory so this should be safe enough
Currently on top of #661 so that should be merged first
@QCoDeS/core