Negative delay warning fix for IVVI driver #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Adriaan_working_branc
…an_working_branc
…an_working_branc
…an_working_branc
…an_working_branc
…an_working_branc
|
looks good 💃 |
|
@alexcjohnson |
|
Oh sorry - absolutely, 💃 BTW, I could have looked at this a long time ago, just didn't see it. I had to turn down my notification level from github because I'd get too much noise from other repos I'm on (I wish I could set notification levels per repo, have raised that issue with github support)... but I still see stuff immediately if you mention me, so feel free to do that liberally. |
nataliejpg
pushed a commit
to nataliejpg/Qcodes
that referenced
this pull request
Aug 30, 2017
* Handle device annotator being run from console with eventloop integration * store ref to imagedrawer Otherwise it may close at any time * Ensure that status is defined * Support annotating with channel devices * use forground qt func * Fix correct function name * use defined names for fallback
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Sep 21, 2017
* Handle device annotator being run from console with eventloop integration * store ref to imagedrawer Otherwise it may close at any time * Ensure that status is defined * Support annotating with channel devices * use forground qt func * Fix correct function name * use defined names for fallback
nataliejpg
pushed a commit
to nataliejpg/Qcodes
that referenced
this pull request
Oct 11, 2017
* Handle device annotator being run from console with eventloop integration * store ref to imagedrawer Otherwise it may close at any time * Ensure that status is defined * Support annotating with channel devices * use forground qt func * Fix correct function name * use defined names for fallback
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Oct 27, 2017
* Handle device annotator being run from console with eventloop integration * store ref to imagedrawer Otherwise it may close at any time * Ensure that status is defined * Support annotating with channel devices * use forground qt func * Fix correct function name * use defined names for fallback
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Nov 21, 2017
* Handle device annotator being run from console with eventloop integration * store ref to imagedrawer Otherwise it may close at any time * Ensure that status is defined * Support annotating with channel devices * use forground qt func * Fix correct function name * use defined names for fallback
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Nov 23, 2017
* Handle device annotator being run from console with eventloop integration * store ref to imagedrawer Otherwise it may close at any time * Ensure that status is defined * Support annotating with channel devices * use forground qt func * Fix correct function name * use defined names for fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in issue #44.
Implements the fix that was allowed by #47.
Tested and am using it now.