Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Alazar drivers #6106

Merged
merged 3 commits into from
May 23, 2024
Merged

Fix Alazar drivers #6106

merged 3 commits into from
May 23, 2024

Conversation

thangleiter
Copy link
Contributor

Fixes #6104.

The example now runs on my end (excepting trigger timeouts, which are likely to be device-sided).

@thangleiter thangleiter requested a review from a team as a code owner May 22, 2024 14:47
Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thangleiter

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.62%. Comparing base (6e27c03) to head (eaedbbc).

Files Patch % Lines
src/qcodes/instrument_drivers/AlazarTech/ATS.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6106   +/-   ##
=======================================
  Coverage   67.62%   67.62%           
=======================================
  Files         352      352           
  Lines       30740    30740           
=======================================
  Hits        20789    20789           
  Misses       9951     9951           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen enabled auto-merge May 22, 2024 19:16
@jenshnielsen jenshnielsen added this pull request to the merge queue May 23, 2024
Merged via the queue into microsoft:main with commit 6f144ff May 23, 2024
19 of 20 checks passed
@thangleiter thangleiter deleted the bugfix/alazar_driver branch May 23, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alazar example (and driver) is broken
2 participants