-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/signadyne driver #575
Feature/signadyne driver #575
Conversation
… as a skeleton for the M3300A combo card.
…e/signadyne_driver
Also removed unnecessary wrapper functions in the base class.
Add a correct get_cmd, since it previously was not a function, rather an evaluated function.
…ers to private attributes with set and get functions.
…ot class variables. This should be convention for all future variables.
Add missing test for testing open/close and chassis/slot related functions.
… parameters can be defined.
Also created internal variable storage to aid get/set commands with first time execution.
change the order of positional arguments of several channel-related set functions so they can be used in 'partial'
add test functions for channel-related set-commands like frequency, phase, amplitude, offset and wave chape
Fixed some missing parentheses.
previously only the get-cmd was available. This commit adds the set-cmd and also add a test function for this parameter.
…iable from parameters.
…d their get cmd definitions.
Add waveform and awg related functions to the M3201A driver. Also add clock and trigger related functions.
Changed library location to be ~/site_packages/signadyne.py to agree with SD AWG driver.
…e used instead of class funcs. Small corrections to some validator declarations.
…be shared with other funcitons.
Add waveform related functions to the M3201A driver and also fix waveform writing convention
Move pxi-read/write functions to SD_Module level. Previously they were in SD_AWG, but they are shared by all SD_Modules.
…re is no real reason to use a get_cmd rather than get_latest for a purely settable device parameter
Add PCport-read and -write functions at SD_Module level. These are used for communicating with the FPGA PCports.
…integration Feature/signadyne digitizer integration
…ates Small Signadyne driver updates
Cleanup of SD driver classes so the have the same naming and functionality conventions.
Add the new awg_queue_config method, that was previously not in the Keysight lib
Add trigger_io parameter to SD_DIG. It uses already existing get and set functions.
Add a correct reference to the SD_AIN_TriggerMode class, which is in the keysightSD1 package.
…anup Feature/signadyne driver cleanup
Remove the SD_DIG_test file since it is practically empty and has no functionality.
…iratie/Qcodes into feature/signadyne_driver
method `set_points_per_cycle` was missing '{}' in the format string
Add decorators `@staticmethod` where methods could be functions.
@jenshnielsen aka master of sphinx. How do we solve the build issue here? |
The tests in test_suite.py need to be skipped if the keysight module is not installed. I would suggest
changing the import to catch any import errors and then decorating the test classes with
Alternatively you can catch the ImportError and raise a unittest.SkipTest in the exception handling but then the tests are not counted correctly by pytest. To make sure the documentation builds without the keysight module you should add it to autodoc_mock_imports here https://github.com/QCoDeS/Qcodes/blob/master/docs/conf.py#L387 |
@lgnjanssen see suggestion from @jenshnielsen (with which I totally agree) and @lgnjanssen super contribution! Thanks |
Make the test suite skip tests if the keysight module is not installed.
Add the keysightSD1 module to autodoc_mock_imports such that the documentation builds without the module installed.
Author: lgnjanssen <[email protected]> dirver: Signadyne driver (#575)
Adds drivers for the Keysight AWG and Digitizer PXIe cards (series M32/M33xxA).
Changes proposed in this pull request:
@giulioungaretti @WilliamHPNielsen @maij