Version testing added ValueError #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a description to notify the user of a version mismatch that is not detected by the simple 'version < required-version' comparison
|
Cool - I'm not sure about the wording 'mismatch' though, makes it sound like we know it's wrong. I might have said something like "The system could not understand version "{}" of package "{}". Please make sure..." |
|
Fair enough. |
|
Beautiful. 💃 |
MerlinSmiles
pushed a commit
that referenced
this pull request
Mar 4, 2016
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Jul 19, 2017
and reset histgram too
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Aug 10, 2017
and reset histgram too
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Aug 16, 2017
and reset histgram too
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Aug 18, 2017
and reset histgram too
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Aug 22, 2017
and reset histgram too
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Sep 21, 2017
and reset histgram too
nataliejpg
pushed a commit
to nataliejpg/Qcodes
that referenced
this pull request
Oct 11, 2017
and reset histgram too
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Oct 27, 2017
and reset histgram too
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Nov 21, 2017
and reset histgram too
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Nov 23, 2017
and reset histgram too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexcjohnson this Closes #52
I Added a description to notify the user of a version mismatch that is not
detected by the simple 'version < required-version' comparison.
I did not do anything with the testing stuff. But the test from within ipyton runs fine.