Fix: restore handling of labels on multi line plots in matplot #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giulioungaretti
approved these changes
Mar 13, 2017
giulioungaretti
pushed a commit
that referenced
this pull request
Mar 13, 2017
Author: Jens Hedegaard Nielsen <[email protected]> Fix: restore handling of labels on multi line plots in matplot (#521)
giulioungaretti
pushed a commit
that referenced
this pull request
Mar 13, 2017
Author: Jens Hedegaard Nielsen <[email protected]> Fix: restore handling of labels on multi line plots in matplot (#521)
giulioungaretti
pushed a commit
that referenced
this pull request
Mar 13, 2017
Author: Jens Hedegaard Nielsen <[email protected]> Fix: restore handling of labels on multi line plots in matplot (#521)
giulioungaretti
pushed a commit
that referenced
this pull request
Mar 13, 2017
Author: Jens Hedegaard Nielsen <[email protected]> Fix: restore handling of labels on multi line plots in matplot (#521)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@QCoDeS/core
Following the merge of #495 trying to do multiple lineplots with matplotlib as in
results in labels such as "None (None)" on both axes. This is because axsetter is called with the string "None (None)" the same issue does not exist for pyqtgraph as it directly supports units and
setLabel is called as
setLabel(None, None)which is simply interpreted as a noopThis pr restores matching behaviour to matplot