Silence pyright warnings #4979
Merged
Silence pyright warnings #4979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4979 +/- ##
=======================================
Coverage 67.84% 67.84%
=======================================
Files 356 356
Lines 32153 32153
=======================================
Hits 21813 21813
Misses 10340 10340 |
jenshnielsen
commented
Feb 7, 2023
astafan8
approved these changes
Feb 7, 2023
These modules may not be installed at type checking time but we have stubs which is fine
jenshnielsen
force-pushed
the
silence_pyright_warnings
branch
from
1e031a6 to
697bf64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modules may not be installed (and cannot on non windows pcs)
Done on top of #4978 which should be merged first