Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to part of test module #4975

Merged
merged 51 commits into from
Feb 6, 2023
Merged

Add types to part of test module #4975

merged 51 commits into from
Feb 6, 2023

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Feb 6, 2023 •
edited
Loading

Primarily validator and parameter tests.

TODO

  • Replace all with Parameter(Raw)DataTypes when possible

@jenshnielsen
Add types to test_arrays
1a7ead1
@jenshnielsen
add types to test_basic
5faecd3
@jenshnielsen
add types to test_numbers
310a198
@jenshnielsen
Allow np.bool_ to bool validator
cbeea61
@jenshnielsen
Cleanup typing of validators
41a73ce
@jenshnielsen
[wip] fix types in test bool
f93c5c3
@jenshnielsen
fix typechecking of test bool validator
13ab32f
@jenshnielsen
fix typechecking of test callable validator
fbb7dfd
@jenshnielsen
fix typechecking of test complex validators
440d705
@jenshnielsen
fix typechecking of test dict validators
c8c06ef
@jenshnielsen
fix typechecking of test enum validators
211021d
@jenshnielsen
Fix typechecking of validator tests ints
d6f726f
@jenshnielsen
fix typecheck of List validator
28de0ec
@jenshnielsen
Add types to some more validator tests
b0fbf09
@jenshnielsen
Fix typecheck of multiples
9dd98b5
@jenshnielsen
Fix typecheck of multitype and
e85dd72
@jenshnielsen
Fix type check in multitype and
b348ded
@jenshnielsen
Correct typing of on off val mapping
bdf2228
@jenshnielsen
add types to parameter conftest
9b3b7ae
@jenshnielsen
Type array parameter tests
6d5f4a0
@jenshnielsen
Type combine parameter tests
b9f066b
@jenshnielsen
add types to snapshot tests
4dfa5d7
@jenshnielsen
combine match signature with combined parameter
2ac9028
@jenshnielsen
Fix type check in parameter validation
90dcc52
@jenshnielsen
Fix typechecking of basic parameter tests
bb6708b
@jenshnielsen
Add types to get latest tests
1a11839
@jenshnielsen
Add types to on off valmapping tests
4d74783
@jenshnielsen
Add type to val mapping tests
f304c20
@jenshnielsen
Add types to parameter cache tests
09e4d8b
@jenshnielsen
Add types to parameter context manger tests
b283d57
astafan8
astafan8 approved these changes Feb 6, 2023
View reviewed changes
qcodes/validators/validators.py Outdated Show resolved Hide resolved
qcodes/validators/validators.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 6, 2023 •
edited
Loading

Codecov Report

Merging #4975 (068232a) into master (6d9330b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4975      +/-   ##
==========================================
- Coverage   68.75%   68.75%   -0.01%     
==========================================
  Files         356      356              
  Lines       32156    32153       -3     
==========================================
- Hits        22109    22106       -3     
  Misses      10047    10047

@jenshnielsen jenshnielsen merged commit 12dbe72 into microsoft:master Feb 6, 2023
@jenshnielsen jenshnielsen deleted the add_types_to_tests_2 branch February 6, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenshnielsen @astafan8