Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add export info metadata to dataset #3135

Merged
merged 26 commits into from
Jun 30, 2021

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jun 18, 2021

This will eventually make it easier to export and reimport datasets

  • Test for meta data being set, written and loaded correctly.
  • A schema (dataclass -> str repr for this data)
  • Let export write to this structure

@jenshnielsen jenshnielsen marked this pull request as draft June 18, 2021 12:16
@jenshnielsen jenshnielsen force-pushed the add_export_info branch 2 times, most recently from 909c372 to ef8892d Compare June 22, 2021 07:40
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #3135 (f94f1c2) into master (4ae08ff) will increase coverage by 0.04%.
The diff coverage is 97.50%.

@@            Coverage Diff             @@
##           master    #3135      +/-   ##
==========================================
+ Coverage   65.73%   65.77%   +0.04%     
==========================================
  Files         216      217       +1     
  Lines       28857    28895      +38     
==========================================
+ Hits        18968    19005      +37     
- Misses       9889     9890       +1     

@jenshnielsen jenshnielsen force-pushed the add_export_info branch 2 times, most recently from 02cc9f2 to 027a643 Compare June 24, 2021 10:02
@jenshnielsen jenshnielsen changed the title add db upgrader that adds an export info column add export info metadata to dataset Jun 24, 2021
@jenshnielsen jenshnielsen added this to the 0.27.0 milestone Jun 25, 2021
@jenshnielsen jenshnielsen marked this pull request as ready for review June 28, 2021 07:04
@jenshnielsen jenshnielsen enabled auto-merge June 28, 2021 07:04
@jenshnielsen jenshnielsen merged commit 6c8f720 into microsoft:master Jun 30, 2021
@jenshnielsen jenshnielsen deleted the add_export_info branch June 30, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants