Generalized N-dimensional dond with sweep objects #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2990 +/- ##
==========================================
+ Coverage 65.55% 65.65% +0.10%
==========================================
Files 216 216
Lines 28638 28746 +108
==========================================
+ Hits 18773 18874 +101
- Misses 9865 9872 +7 |
|
Update: |
Akshita07
reviewed
May 25, 2021
Akshita07
reviewed
May 25, 2021
Akshita07
reviewed
May 25, 2021
Akshita07
reviewed
May 25, 2021
Akshita07
reviewed
May 25, 2021
Akshita07
reviewed
May 25, 2021
Akshita07
reviewed
May 25, 2021
Akshita07
reviewed
May 25, 2021
Akshita07
reviewed
May 25, 2021
|
@FarBo I added some suggestions inline. Before we do that I think we should get some tests written and start with that and do some proper tdd |
… into FarBo/qtransport_dond
Dond fixes
|
@FarBo @astafan8 I have opened a pr here to nicely format all the changed code with darker https://github.com/FarBo/Qcodes/pull/22/files |
jenshnielsen
approved these changes
Jun 8, 2021
rerun darker -i -r master
… into FarBo/qtransport_dond
astafan8
approved these changes
Jun 8, 2021
astafan8
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the generalized dond function.
Actions are still missing to be implemented and they could be added after reviewing the current implementation.
Do we also need flush_columns like do2d?
Following taks will be addressed after completion of dond function.
@jenshnielsen
@astafan8