Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package structure #22

Merged
merged 4 commits into from
Feb 8, 2016
Merged

Package structure #22

merged 4 commits into from
Feb 8, 2016

Conversation

alexcjohnson
Copy link
Contributor

@eendebakpt Thanks for prodding me to do this - we would have had to sometime not too long anyway, to make qcodes pip-installable, but what I didn't know about is setup.py develop, which leaves the code where it is but links it to python the right way so the package is globally discoverable. so (cc @AdriaanRol ) no more monkeying with sys.path

Also notice that the test command is simplified now: you can do python setup.py nosetests because I put the coverage config into setup.cfg

However, I didn't solve your exact dependency issue @eendebakpt - because it seems to me matplotlib and pyqtgraph are both potentially tricky to install, so I left them as optional dependencies. They're still in setup.py as well as README.md but they won't be automatically upgraded.

@alexcjohnson
Copy link
Contributor Author

Any comments before I merge this? Going once... going twice...

@AdriaanRol
Copy link
Contributor

I didn't have time to test if it actually works but the code itself looks good 💃

@eendebakpt
Copy link
Contributor

I didn't know about setup.py develop, but it works like a charm. Please merge!

I would like to add with-doctest=1 to setup.cfg, because I like doctest. Currently this conflicts with py35_syntax.py (I work with python 3.4), I have not figured out how to solve this.

@alexcjohnson
Copy link
Contributor Author

Thanks @AdriaanRol
@eendebakpt great! I will look into with-doctest=1 as a separate PR

alexcjohnson added a commit that referenced this pull request Feb 8, 2016
@alexcjohnson alexcjohnson merged commit be178a7 into master Feb 8, 2016
@alexcjohnson alexcjohnson deleted the package branch February 8, 2016 13:27
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Apr 5, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Apr 10, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes May 2, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Jun 1, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Jun 22, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Jun 27, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Jul 7, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Jul 18, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 3, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 3, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 7, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 9, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 10, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 16, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 18, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Aug 22, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Sep 21, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
nataliejpg pushed a commit to nataliejpg/Qcodes that referenced this pull request Oct 11, 2017
…ormesh in pdf (microsoft#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Oct 27, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Nov 21, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
jenshnielsen referenced this pull request in jenshnielsen/Qcodes Nov 23, 2017
…ormesh in pdf (#22)

* Fix: only pass color to plot.add when doing a 1d plot

Otherwise artifacts will be added to 2d plot this requires a hack

* Fix: rasterize pcolormesh plots in pdf

Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly

* fix: only add grid to 1d plots in pdf
astafan8 pushed a commit that referenced this pull request Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants