-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package structure #22
Conversation
Any comments before I merge this? Going once... going twice... |
I didn't have time to test if it actually works but the code itself looks good 💃 |
I didn't know about setup.py develop, but it works like a charm. Please merge! I would like to add with-doctest=1 to setup.cfg, because I like doctest. Currently this conflicts with py35_syntax.py (I work with python 3.4), I have not figured out how to solve this. |
Thanks @AdriaanRol |
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (microsoft#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
…ormesh in pdf (#22) * Fix: only pass color to plot.add when doing a 1d plot Otherwise artifacts will be added to 2d plot this requires a hack * Fix: rasterize pcolormesh plots in pdf Significantly speeds up saving from 1m47s to 0.7s on my machine (100,5000) array. and makes pdfs that can be opened quickkly * fix: only add grid to 1d plots in pdf
@eendebakpt Thanks for prodding me to do this - we would have had to sometime not too long anyway, to make qcodes pip-installable, but what I didn't know about is
setup.py develop
, which leaves the code where it is but links it to python the right way so the package is globally discoverable. so (cc @AdriaanRol ) no more monkeying withsys.path
Also notice that the test command is simplified now: you can do
python setup.py nosetests
because I put the coverage config intosetup.cfg
However, I didn't solve your exact dependency issue @eendebakpt - because it seems to me matplotlib and pyqtgraph are both potentially tricky to install, so I left them as optional dependencies. They're still in
setup.py
as well asREADME.md
but they won't be automatically upgraded.