Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fxcop] Fixes for Wox.Plugin (1of3) #7457

Merged
merged 31 commits into from
Oct 26, 2020
Merged

[fxcop] Fixes for Wox.Plugin (1of3) #7457

merged 31 commits into from
Oct 26, 2020
+430 −95

Commits on Oct 9, 2020

  1. Merge pull request #1 from microsoft/master 

    Pulling in changes from microsoft/PowerToys
    @avneet-kr
    avneet-kr authored Oct 9, 2020
    Configuration menu
    Copy the full SHA
    504f076 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Merge pull request #2 from microsoft/master 

    Merging in changes from microsoft/master
    @avneet-kr
    avneet-kr authored Oct 15, 2020
    Configuration menu
    Copy the full SHA
    daa3342 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Merge branch 'master' of github.com:avneet-kr/PowerToys into master

    @avneet-kr
    avneet-kr committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    e23d846 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. Merge branch 'master' of github.com:avneet-kr/PowerToys into master

    @avneet-kr
    avneet-kr committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    48b7b2e View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2020

  1. Merge branch 'master' of github.com:avneet-kr/PowerToys into master

    @avneet-kr
    avneet-kr committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    da924fc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:avneet-kr/PowerToys into master

    @avneet-kr
    avneet-kr committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    2eb2191 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Merge branch 'master' of github.com:avneet-kr/PowerToys into master

    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    0506145 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:avneet-kr/PowerToys into master

    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    0744d2f View commit details
    Browse the repository at this point in the history

  3. Enabled FxCopAnalyzer for Wox.Plugin

    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    06053a4 View commit details
    Browse the repository at this point in the history

  4. Added CultureInfo (CA1307: Specify StringComparison for clarity / CA1… 

    …304: Specify CultureInfo)
    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    6554c01 View commit details
    Browse the repository at this point in the history

  5. Check arguments and throw ArgumentNullException (CA1062: Validate arg… 

    …uments of public methods)
    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    6124591 View commit details
    Browse the repository at this point in the history

  6. Changed url parameter from string to System.Uri and added null checks… 

    … (CA1054: URI parameters should not be strings)
    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    556c6b4 View commit details
    Browse the repository at this point in the history

  7. Rethrow exception without specifying the exception explicitly (CA2200… 

    …: Rethrow to preserve stack details)
    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    58a91dd View commit details
    Browse the repository at this point in the history

  8. Changed from Collection property to methods for PluginMetadata::Actio… 

    …nKeywords (CA2227: Collection properties should be read only)
    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    5723f6e View commit details
    Browse the repository at this point in the history

  9. Changed from Collection property to methods for Result::GetTitleHighl… 

    …ightData (CA2227: Collection properties should be read only)
    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    8a55369 View commit details
    Browse the repository at this point in the history

  10. Made Collection property read-only and added parameter in constructor… 

    … for Result::SubTitleHighlightData (CA2227: Collection properties should be read only)
    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    3ee0980 View commit details
    Browse the repository at this point in the history

  11. Made Collection property read only and added parameter in constructor… 

    … for ResultUpdatedEventArgs::Results (CA2227: Collection properties should be read only)
    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    cb4c580 View commit details
    Browse the repository at this point in the history

  12. CA1507: Use nameof in place of string

    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    7f6c3a5 View commit details
    Browse the repository at this point in the history

  13. Removed initialization for ThemeManager::_disposed (CA1805: Do not in… 

    …itialize unnecessarily)
    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    64dc964 View commit details
    Browse the repository at this point in the history

  14. Changed Query::Terms array property to ReadOnlyCollection and added p… 

    …rivate set (CA1819: Properties should not return arrays)
    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    014841b View commit details
    Browse the repository at this point in the history

  15. CA1060: Move P/Invokes to NativeMethods class

    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    7a7185f View commit details
    Browse the repository at this point in the history

  16. CA1806: Do not ignore method results

    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    10fe6c6 View commit details
    Browse the repository at this point in the history

  17. CA2101: Specify marshaling for P/Invoke string arguments

    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    704e177 View commit details
    Browse the repository at this point in the history

  18. Removed unnecessary empty interface IFeatures (CA1040: Avoid empty in… 

    …terfaces)

- Removed IFeatures interface and references
- Renamed IFeatures.cs to IContextMenu.cs according to guidelines
    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    a683a43 View commit details
    Browse the repository at this point in the history

  19. Added comments for CultureInfo (CA1307: Specify StringComparison for … 

    …clarity / CA1304: Specify CultureInfo)
    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    731d71e View commit details
    Browse the repository at this point in the history

  20. Reverted "Enabled FxCopAnalyzer for Wox.Plugin" 

    This reverts commit f721c2f.
    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    fe7aad3 View commit details
    Browse the repository at this point in the history

  21. Merge branch 'master' of github.com:avneet-kr/PowerToys into master

    @avneet-kr
    avneet-kr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    b9ab10d View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Merge branch 'master' of github.com:avneet-kr/PowerToys into master

    @avneet-kr
    avneet-kr committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    94eab4e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:avneet-kr/PowerToys into master

    @avneet-kr
    avneet-kr committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    68f9cc6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into FxCopAnalyzer_WoxPlugin

    @avneet-kr
    avneet-kr committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    4540b43 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. Added localization for Wox.Plugin and localized strings in FilesFolde… 

    …rs.cs
    @avneet-kr
    avneet-kr committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    26e333b View commit details
    Browse the repository at this point in the history