Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] Sort Languages ComboBox #35462

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

davidegiacometti
Copy link
Collaborator

Summary of the Pull Request

Sort the languages ComboBox keeping the default on top.

PR Checklist

Detailed Description of the Pull Request / Additional comments

The importance of using StringComparison.CurrentCultureIgnoreCase can be noted using Portuguese.

image

Validation Steps Performed

Tested using PowerToys.Settings.pri from the latest stable build.

  • Verified that the languages in the ComboBox are sorted with the default on top
  • Switched multiple languages
  • Verified that the UI and language.json are in sync

@davidegiacometti
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@stefansjfw stefansjfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Thanks!

@jaimecbernardo jaimecbernardo merged commit 14139af into main Oct 18, 2024
16 checks passed
@davidegiacometti davidegiacometti deleted the users/davidegiacometti/sort-languages branch October 23, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants