Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT Run][VS Code Workspaces] Do not check WSL paths #31351

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

stefansjfw
Copy link
Collaborator

@stefansjfw stefansjfw commented Feb 8, 2024

Summary of the Pull Request

This was caused because of the permission issues. If WSL VS Code workspace is located on Windows file system partitions (e.g. C:/), checking WSL paths as \wsl.localhost\Ubuntu\mnt\c<...> are inaccessible from Windows file system. Reason and more info microsoft/WSL#8512 (comment)

Same happens if you try to open C partition from Explorer within WSL File system:
image

As a result, these paths were considered non-existent which is not true. Therefore, skipping this check for WSL workspaces. This will still show some WSL workspaces that were possibly removed in the meantime but this is better than not showing existing workspaces

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! Great work finding what was happening here?

@jaimecbernardo jaimecbernardo merged commit dec535e into main Feb 8, 2024
14 checks passed
@crutkas crutkas deleted the stefan/fix_31231 branch February 13, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants