Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MWB] improve UX for Uninstall service when it's inaccessible #26525

Merged
merged 1 commit into from
May 31, 2023
Merged

[MWB] improve UX for Uninstall service when it's inaccessible #26525

merged 1 commit into from
May 31, 2023

Conversation

yuyoyuppe
Copy link
Contributor

Summary of the Pull Request

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

When running as admin:

before:
image

after:
image

jaimecbernardo
jaimecbernardo approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jaimecbernardo jaimecbernardo added the Hot Fix Items we will product an out-of-band release for label May 31, 2023
@jaimecbernardo jaimecbernardo merged commit e378f0c into microsoft:main May 31, 2023
@yuyoyuppe yuyoyuppe deleted the mwb_settings_ux_fix_for_uninstall_service branch May 31, 2023 16:18
BLM16 pushed a commit to BLM16/PowerToys that referenced this pull request Jun 22, 2023
@yuyoyuppe @BLM16
[MWB]Improve UX for Uninstall service when it's inaccessible (microso…
78335d6 
…ft#26525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

Assignees
No one assigned
Labels
Hot Fix Items we will product an out-of-band release for
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuyoyuppe @jaimecbernardo