[GPO; Enterprise] Updater policies #24221

htcfreek · 2023-02-20T13:06:19Z

Summary of the Pull Request

This PR adds the following three updater policies:

Disable automatic download.
Suspend toast notification from periodic check for two minor releases.
Disable automatic background update check. (This GPO will be implemented for later usage, but not active.)

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

TESTED:

Disable periodic update GPO.
Disable automatic download GPO.

NOT TESTED (Not possible for me.):

Suspend toast notification GPO.

htcfreek · 2023-02-20T13:07:52Z

@snickler, @jaimecbernardo
I get this error when building locally:

Severity	Code	Description	Project	File	Line	Suppression State
Error	C1083	Cannot open include file: 'GPOWrapper.g.h': No such file or directory (compiling source file UpdateUtils.cpp)	runner	D:\AppDev\Github\htcfreek\PT_UpdateGpo\src\common\GPOWrapper\GPOWrapper.h	2

Do you have an idea why?

snickler · 2023-02-20T13:10:27Z

@snickler, @jaimecbernardo
I get this error when building locally:

Severity	Code	Description	Project	File	Line	Suppression State
Error	C1083	Cannot open include file: 'GPOWrapper.g.h': No such file or directory (compiling source file UpdateUtils.cpp)	runner	D:\AppDev\Github\htcfreek\PT_UpdateGpo\src\common\GPOWrapper\GPOWrapper.h	2

Do you have an idea why?

I would say to try running the powershell to remove the generated directories and build again using msbuild. I will also try building to see if I can repro

htcfreek · 2023-02-20T13:13:04Z

@snickler, @jaimecbernardo
I get this error when building locally:
Severity	Code	Description	Project	File	Line	Suppression State
Error	C1083	Cannot open include file: 'GPOWrapper.g.h': No such file or directory (compiling source file UpdateUtils.cpp)	runner	D:\AppDev\Github\htcfreek\PT_UpdateGpo\src\common\GPOWrapper\GPOWrapper.h	2	
Do you have an idea why?
I would say to try running the powershell to remove the generated directories and build again using msbuild. I will also try building to see if I can repro

Is it auto generated? I can't find it in the folder structure.

snickler · 2023-02-20T13:14:40Z

@snickler, @jaimecbernardo
I get this error when building locally:
Severity	Code	Description	Project	File	Line	Suppression State
Error	C1083	Cannot open include file: 'GPOWrapper.g.h': No such file or directory (compiling source file UpdateUtils.cpp)	runner	D:\AppDev\Github\htcfreek\PT_UpdateGpo\src\common\GPOWrapper\GPOWrapper.h	2	
Do you have an idea why?
I would say to try running the powershell to remove the generated directories and build again using msbuild. I will also try building to see if I can repro
Is it auto generated? I can't find it in the folder structure.

Yup it's generated. Oh, also nuke all Msbuild.exe and VBCSCompiler.exe instances before you try again

snickler · 2023-02-20T13:51:10Z

Hmmm I'm unsure why this is failing to build properly. I want to say it could be something not matching with the changes that it's failing to create the generated file needed. I'll dig in and see what I can find.

snickler · 2023-02-20T14:27:44Z

@htcfreek - Oh, I think I know what it is. It's likely because of UpdateUtils directly including the GPOWrapper.h. Since that GPOWrapper.g.h it's referencing is generated during the build of the GPOWrapper project, it's probably not going to be in existence at the time of it being referenced by the updater. There may be some compilation based things that have to do or maybe some ifdefs around including GPOWrapper.g.h? I'm not 100% sure.

htcfreek · 2023-02-20T14:35:09Z

@snickler
I finish the PR and then @jaimecbernardo can hopefully help me with fixing the build. It is my first time coding C++, so I don't know how to fix it.

snickler · 2023-02-20T14:36:22Z

@snickler
I finish the PR and then @jaimecbernardo can hopefully help me with fixing the build. It is my first time coding C++, so I don't know how to fix it.

Ha, I think I fixed it.

htcfreek · 2023-02-20T14:36:56Z

@snickler
I finish the PR and then @jaimecbernardo can hopefully help me with fixing the build. It is my first time coding C++, so I don't know how to fix it.

Ha, I think I fixed it.

Nice. Can you tell me how or push the fix?

Added relative path to Generated Files folder for GPOWrapper.g.h

snickler · 2023-02-20T14:40:24Z

@snickler
I finish the PR and then @jaimecbernardo can hopefully help me with fixing the build. It is my first time coding C++, so I don't know how to fix it.

Ha, I think I fixed it.

Nice. Can you tell me how or push the fix?

I just pushed the change to it that worked locally for me. I added the Generated Files path to the include and that seemed to be fine

…into PT_UpdateGpo

snickler · 2023-02-20T15:20:00Z

Looks like the arm64 build completed successfully. I'm sure there's probably a BETTER way of doing this. I wonder if it would be better to add the Generated Files folder for GPOWrapper into the additional include directories for the runner project rather than hardcoding the directory name in GPOWrapper.h? @jaimecbernardo thoughts?

htcfreek · 2023-02-21T10:50:10Z

@niels9001, @stefansjfw , @snickler I investigated the visibility property (IsAdmin) of the AutoDownload settings card and found out that it his hidden for normal users who not a member of the Admin group. Because we normal only disable the card with an info bar, we now have a GPO and because I don't see any reason why we should block normal users from changing AND SEEING this setting, I decided to improve UI here. I will do this in this PR because I don't like to do things twice.

I have check the issue and PR history. It seems that we decide to not show the setting to normal users, because they should not enable it. We don't want this because the can't install the updates. (See also #2885.)

src/gpo/assets/en-US/PowerToys.adml

htcfreek · 2023-02-23T07:51:00Z

@jaimecbernardo , @stefansjfw
Feedback is addressed

stefansjfw · 2023-02-23T15:59:54Z

src/settings-ui/Settings.UI/ViewModels/GeneralViewModel.cs

+            get => !AutoUpdatesDisabledOnDevBuild && !_autoDownloadUpdatesIsGpoDisabled;
+        }
+
+        // The settings card is hidden for users who are not a member of the Administrators group and in this case the GPO info should be hidden too.


note that this will be changed once per-user installer is out

Okay. But then we need to update it after user install is out. I only improved code.

Currently it is hidden so gpo message should be too.

And btw, I think this will be related to the install mode. If PT is installed as admin a user still has no permissions.

yeah, yeah, it was note to myself mostly :)

stefansjfw

lgtm

htcfreek · 2023-02-23T16:32:23Z

@stefansjfw
Yesterday I had the idea that we can allow suspending major release toasts for e.g. 8 weeks (=2 minor releases). But therefore we need to convert the GH release date string to a DateTime object. And I don't know how to do this in C++. - But this can be an improvement for later.

stefansjfw

Settings card is not disabled when version is != 0.0.1. Also info bar not displayed. @htcfreek can you double-check that?

htcfreek · 2023-02-23T18:52:42Z

Settings card is not disabled when version is != 0.0.1. Also info bar not displayed. @htcfreek can you double-check that?

@stefansjfw

~~Settings card makes sense. My mistake we need a single & in the ViewModel property.~~
Are you running as normal user or do you debugging? (I know there is one case where the IsAdmin property is wrong. ~~And btw, here we have the same mistake: We need a single &.~~

Edit: Bug found.

stefansjfw · 2023-02-23T18:54:13Z

Are you running as normal user or do you debugging?

Tested fully installed PT

src/gpo/assets/PowerToys.admx

stefansjfw

Looks good now :)

htcfreek · 2023-02-23T20:08:56Z

Then you can merge it. I don't have the permissions.

jaimecbernardo · 2023-02-24T13:36:25Z

src/settings-ui/Settings.UI/ViewModels/GeneralViewModel.cs

@@ -272,11 +274,20 @@ public bool IsAdmin
            }
        }

+        // Are we running a dev build? (Please note that we verify this in the code that gets the newest version from Github too.)


I'll update this one.

jaimecbernardo · 2023-02-24T14:38:33Z

Thanks a lot for the contribution @htcfreek ! 🎉

* Implement GPO * Add GPOs in updater * Rename policy * fix * fix * Update GPOWrapper.h Added relative path to Generated Files folder for GPOWrapper.g.h * fix and inactivate PeriodicUpdateCheck gpo * Docs * GPO name change * Templates * Templates: Text changes * Templates: Text changes * Templates: Text changes * docs: spell fix * settings ui * fixes * fixes * fix gpo description * EOF fix * Fix include in UpdateUtils.cpp and remove build workaround * UI improvements * spell fixes * code improvements * Update README.md * Update PowerToys.adml * Update src/gpo/assets/PowerToys.admx * Remove forbidden pattern

htcfreek added 5 commits February 20, 2023 11:11

Implement GPO

bd91f0c

Add GPOs in updater

79ade45

Rename policy

24b6957

fix

bfb4896

fix

35a5413

Update GPOWrapper.h

5672af7

Added relative path to Generated Files folder for GPOWrapper.g.h

htcfreek added 5 commits February 20, 2023 15:40

fix and inactivate PeriodicUpdateCheck gpo

a2d940c

Merge branch 'PT_UpdateGpo' of https://github.com/htcfreek/PowerToys …

fd9befe

…into PT_UpdateGpo

Docs

e345b80

GPO name change

867651c

Templates

3254720

Templates: Text changes

8f72556

This comment has been minimized.

Sign in to view

Templates: Text changes

3869e9b

This comment has been minimized.

Sign in to view

Templates: Text changes

351d911

This comment has been minimized.

Sign in to view

docs: spell fix

ac02c5e

htcfreek mentioned this pull request Feb 20, 2023

[installer] Support per-user installation #24087

Merged

11 tasks

UI improvements

7d97697

This comment has been minimized.

Sign in to view

htcfreek added 2 commits February 21, 2023 11:55

spell fixes

f74bc32

code improvements

5adca61

htcfreek marked this pull request as ready for review February 21, 2023 12:10

htcfreek requested a review from niels9001 February 21, 2023 12:10

stefansjfw reviewed Feb 21, 2023

View reviewed changes

src/gpo/assets/en-US/PowerToys.adml Outdated Show resolved Hide resolved

src/gpo/assets/en-US/PowerToys.adml Outdated Show resolved Hide resolved

htcfreek added 2 commits February 23, 2023 08:48

Update README.md

51633e6

Update PowerToys.adml

28b48ea

Merge branch 'main' into PT_UpdateGpo

31ad44d

stefansjfw reviewed Feb 23, 2023

View reviewed changes

stefansjfw approved these changes Feb 23, 2023

View reviewed changes

stefansjfw requested changes Feb 23, 2023

View reviewed changes

htcfreek commented Feb 23, 2023

View reviewed changes

src/gpo/assets/PowerToys.admx Outdated Show resolved Hide resolved

Update src/gpo/assets/PowerToys.admx

ffed5e1

stefansjfw approved these changes Feb 23, 2023

View reviewed changes

jaimecbernardo reviewed Feb 24, 2023

View reviewed changes

jaimecbernardo added 2 commits February 24, 2023 13:36

Remove forbidden pattern

75a3cf3

Merge branch 'main' into PT_UpdateGpo

a99191b

jaimecbernardo merged commit 6750442 into microsoft:main Feb 24, 2023

htcfreek deleted the PT_UpdateGpo branch February 25, 2023 10:04

htcfreek mentioned this pull request Feb 27, 2023

[Enterprise; GPO] Updater notifications GPO: Improve behavior on new major releases #24362

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GPO; Enterprise] Updater policies #24221

[GPO; Enterprise] Updater policies #24221

htcfreek commented Feb 20, 2023 •

edited

Loading

htcfreek commented Feb 20, 2023

snickler commented Feb 20, 2023

htcfreek commented Feb 20, 2023

snickler commented Feb 20, 2023

snickler commented Feb 20, 2023

snickler commented Feb 20, 2023

htcfreek commented Feb 20, 2023

snickler commented Feb 20, 2023

htcfreek commented Feb 20, 2023

snickler commented Feb 20, 2023

snickler commented Feb 20, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

htcfreek commented Feb 21, 2023 •

edited

Loading

htcfreek commented Feb 23, 2023

stefansjfw Feb 23, 2023

htcfreek Feb 23, 2023 •

edited

Loading

stefansjfw Feb 23, 2023

stefansjfw left a comment

htcfreek commented Feb 23, 2023 •

edited

Loading

stefansjfw left a comment

htcfreek commented Feb 23, 2023 •

edited

Loading

stefansjfw commented Feb 23, 2023

stefansjfw left a comment

htcfreek commented Feb 23, 2023

jaimecbernardo Feb 24, 2023

jaimecbernardo commented Feb 24, 2023

[GPO; Enterprise] Updater policies #24221

[GPO; Enterprise] Updater policies #24221

Conversation

htcfreek commented Feb 20, 2023 • edited Loading

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

htcfreek commented Feb 20, 2023

snickler commented Feb 20, 2023

htcfreek commented Feb 20, 2023

snickler commented Feb 20, 2023

snickler commented Feb 20, 2023

snickler commented Feb 20, 2023

htcfreek commented Feb 20, 2023

snickler commented Feb 20, 2023

htcfreek commented Feb 20, 2023

snickler commented Feb 20, 2023

snickler commented Feb 20, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

htcfreek commented Feb 21, 2023 • edited Loading

htcfreek commented Feb 23, 2023

stefansjfw Feb 23, 2023

Choose a reason for hiding this comment

htcfreek Feb 23, 2023 • edited Loading

Choose a reason for hiding this comment

stefansjfw Feb 23, 2023

Choose a reason for hiding this comment

stefansjfw left a comment

Choose a reason for hiding this comment

htcfreek commented Feb 23, 2023 • edited Loading

stefansjfw left a comment

Choose a reason for hiding this comment

htcfreek commented Feb 23, 2023 • edited Loading

stefansjfw commented Feb 23, 2023

stefansjfw left a comment

Choose a reason for hiding this comment

htcfreek commented Feb 23, 2023

jaimecbernardo Feb 24, 2023

Choose a reason for hiding this comment

jaimecbernardo commented Feb 24, 2023

htcfreek commented Feb 20, 2023 •

edited

Loading

htcfreek commented Feb 21, 2023 •

edited

Loading

htcfreek Feb 23, 2023 •

edited

Loading

htcfreek commented Feb 23, 2023 •

edited

Loading

htcfreek commented Feb 23, 2023 •

edited

Loading