Update the KBM UI to use a Grid based layout rather than stack panels #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunbalgovind
added
the
Product-Keyboard Shortcut Manager
This was referenced Apr 22, 2020
traies
approved these changes
Apr 22, 2020
Comment on lines
+40
to
+63
| void KeyDropDownControl::SetSelectionHandler(Grid& table, StackPanel& singleKeyControl, size_t colIndex, std::vector<std::vector<DWORD>>& singleKeyRemapBuffer) | ||
| { | ||
| dropDown.SelectionChanged([&, table, singleKeyControl, colIndex](winrt::Windows::Foundation::IInspectable const& sender, SelectionChangedEventArgs const& args) { | ||
| ComboBox currentDropDown = sender.as<ComboBox>(); | ||
| int selectedKeyIndex = currentDropDown.SelectedIndex(); | ||
| // Get row index of the single key control | ||
| uint32_t controlIndex; | ||
| bool indexFound = table.Children().IndexOf(singleKeyControl, controlIndex); | ||
| if (indexFound) | ||
| { | ||
| int rowIndex = (controlIndex - 2) / 3; | ||
| // Check if the element was not found or the index exceeds the known keys | ||
| if (selectedKeyIndex != -1 && keyCodeList.size() > selectedKeyIndex) | ||
| { | ||
| singleKeyRemapBuffer[rowIndex][colIndex] = keyCodeList[selectedKeyIndex]; | ||
| } | ||
| else | ||
| { | ||
| // Reset to null if the key is not found | ||
| singleKeyRemapBuffer[rowIndex][colIndex] = NULL; | ||
| } | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
I don't thing it is a good idea to put the SelectionHandler code for each Dialog here. The SetSelectionHandler method should just receive a callback function and set it as the handler for the SelectionChanged event.
There was a problem hiding this comment.
The main problem in moving it, is the keyCodeList vector is a member of the KeyDropDownControl class. So I can't define the lambda outside the class and pass the keyCodeList as a callback since that variable does not exist in the parent class.
…arbalgov/dynamicLayout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR changes the approach of adding the controls on the edit keyboard and edit shortcut window from stack panels to a single grid with three columns. Rows are dynamically added on clicking the + key. The header was also changed to a relative layout. The PR also fixes an indexing bug, where adding and deleting rows in the tables could result in errors on applying the settings.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Screenshots