Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Image To Text]Rename PowerOCR to Text Extractor #20178

Merged
merged 6 commits into from
Aug 31, 2022

Conversation

jaimecbernardo
Copy link
Collaborator

@jaimecbernardo jaimecbernardo commented Aug 30, 2022

Summary of the Pull Request

Renames PowerPCR to Text Extractor, changing the user facing strings.

PR Checklist

  • Closes: Paste Text from Image #4371
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Renames PowerOCR to Text Extractor, changing the user facing strings. (executables not included)

Validation Steps Performed

Built and verified Settings, OOBE and logs changed.

@Jay-o-Way
Copy link
Collaborator

Hm, why this change? Now it sounds like a file converter. As if it makes a txt or docx file or something...

Copy link
Collaborator

@stefansjfw stefansjfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@htcfreek
Copy link
Collaborator

I personally don't like the name. It feels a bit complicated for a smart utility. I'd suggest something like TextCopy, TextCapture, TextCatch. I personally think we should have focus on getting text into clipboard.

@jaimecbernardo
Copy link
Collaborator Author

@crutkas

@crutkas
Copy link
Member

crutkas commented Aug 30, 2022

aka.ms/PowerToysOverview_ImageToText is created, points to https://docs.microsoft.com/windows/powertoys/image-to-text.md

@jaimecbernardo
Copy link
Collaborator Author

After merging this and #20176, menu order for Settings and OOBE needs to be changed in a further PR, to keep alphabetical order.

@Jay-o-Way
Copy link
Collaborator

menu order for Settings and OOBE needs to be changed in a further PR, to keep alphabetical order.

to keep alphabetical order in English.

@crutkas
Copy link
Member

crutkas commented Aug 30, 2022

Reason for changing was a few items

  1. we need to move away from "Power" prefix
  2. Descriptive names are helpful,
  3. PowerOCR implies you know what OCR actually is.

@cinnamon-msft hey friend, any opinion?

@cinnamon-msft
Copy link
Collaborator

I like TextCapture!

<data name="PowerOCR_Name" xml:space="preserve">
<value>PowerOCR</value>
<data name="ImageToText_Name" xml:space="preserve">
<value>Image To Text</value>
Copy link
Collaborator

@htcfreek htcfreek Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comment that we mean to like convert to. Otherwise we might get translation problems because to can have different meanings (send to, convert to, copy to).

For germany:

  • send to = senden an
  • convert to = konvertieren in
  • copy to = kopieren nach

@htcfreek
Copy link
Collaborator

@jaimecbernardo
Do we rename to "TextCapture" or do we keep what we have?

@jaimecbernardo
Copy link
Collaborator Author

"Image to Text" is just the most descriptive. "Text Capture" from example might be from audio.

@jaimecbernardo
Copy link
Collaborator Author

"Text Extractor" is what might end up being here.

@htcfreek
Copy link
Collaborator

htcfreek commented Aug 31, 2022

"Text Extractor" is what might end up being here.

Sounds good to. 👍🏻

If we not rename anything please add the comment I mentioned im my review.

@jaimecbernardo jaimecbernardo changed the title [Image To Text]Rename PowerOCR to Image To Text [Image To Text]Rename PowerOCR to Text Extractor Aug 31, 2022
@jaimecbernardo
Copy link
Collaborator Author

The new name is to be "Text Extractor".
@crutkas, the link is https://aka.ms/PowerToysOverview_TextExtractor

@crutkas
Copy link
Member

crutkas commented Aug 31, 2022

@jaimecbernardo jaimecbernardo merged commit 086eb58 into main Aug 31, 2022
@TheJoeFin
Copy link
Collaborator

I love Text Extractor! Also because the utility works with anything on screen, video, Teams calls, text within application chrome, and of course images too 😄

@crutkas crutkas deleted the dev/jaime/renamePowerOCR branch October 14, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants