Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging by upper part of application bar doesn't trigger fancy zones display - fix #1953

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Dragging by upper part of application bar doesn't trigger fancy zones display - fix #1953

merged 2 commits into from
Apr 8, 2020

Conversation

PrzemyslawTusinski
Copy link
Contributor

@PrzemyslawTusinski PrzemyslawTusinski commented Apr 6, 2020 •
edited
Loading

Summary of the Pull Request

  • changed method of detecting if movSizeEvent is move or resize. Application now checks if cursor is set to resize type

PR Checklist

Validation Steps Performed

  • tested manualy
  • tested on custom cursors and works as expected

@PrzemyslawTusinski PrzemyslawTusinski changed the title Dragging by upper part of application bar doesn't trigger fancy zones… Dragging by upper part of application bar doesn't trigger fancy zones display Apr 6, 2020
@PrzemyslawTusinski PrzemyslawTusinski changed the title Dragging by upper part of application bar doesn't trigger fancy zones display Dragging by upper part of application bar doesn't trigger fancy zones display - fix Apr 6, 2020
yuyoyuppe
yuyoyuppe approved these changes Apr 6, 2020
View reviewed changes
src/modules/fancyzones/lib/FancyZones.cpp Outdated Show resolved Hide resolved
@yuyoyuppe
Copy link
Collaborator

tested with slack and vs2019 - it works.

SeraphimaZykova
SeraphimaZykova approved these changes Apr 6, 2020
View reviewed changes
Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested with templates and custom layouts

yevhenii44-zz
yevhenii44-zz approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@yevhenii44-zz yevhenii44-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
Manually tested and it fix works for me

ivan100sic
ivan100sic approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@ivan100sic ivan100sic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually with a few apps with a modern UI and a few "traditional" apps, code looks good, all unit tests pass.

@PrzemyslawTusinski PrzemyslawTusinski merged commit d95e49b into microsoft:master Apr 8, 2020
@PrzemyslawTusinski PrzemyslawTusinski deleted the fancyzones_move_detection_method_change branch April 8, 2020 13:12
@snyk-bot snyk-bot mentioned this pull request Dec 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuyoyuppe yuyoyuppe yuyoyuppe approved these changes

@SeraphimaZykova SeraphimaZykova SeraphimaZykova approved these changes

@ivan100sic ivan100sic ivan100sic approved these changes

@yevhenii44-zz yevhenii44-zz yevhenii44-zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PrzemyslawTusinski @yuyoyuppe @SeraphimaZykova @ivan100sic @yevhenii44-zz