FZ: can't drag elevated warning is shown every hour instead of of once per launch #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan100sic
approved these changes
Mar 31, 2020
ivan100sic
reviewed
Mar 31, 2020
ivan100sic
reviewed
Apr 1, 2020
| static std::time_t warning_shown_at = 0; | ||
| constexpr int64_t warning_cooldown_interval_minutes = 60; | ||
| const auto now = timeutil::now(); | ||
| const bool warning_ready = timeutil::diff::in_minutes(now, warning_shown_at) > warning_cooldown_interval_minutes; |
There was a problem hiding this comment.
This will actually take 61 minutes :)
There was a problem hiding this comment.
I guess we have to fire yuyoyuppe.
There was a problem hiding this comment.
We should create a separate task for it, since it's not a one-minute issue.
ivan100sic
approved these changes
Apr 1, 2020
|
Let's wait before merging this. |
|
Let's close this one for now, but please keep the branch since we may revisit it later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
Validation Steps Performed