Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PT Run plugins icons and author #14828

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

davidegiacometti
Copy link
Collaborator

Summary of the Pull Request

What is this about:
Update plugins icons and author on PT Run startup.

What is include in the PR:

How does someone test / validate:

  • Edit %LOCALAPPDATA%\Microsoft\PowerToys\PowerToys Run\settings.json changing icons and author for some plugins.
  • Verify that with 0.51.1 in Plugin Manager icons and author are broken
  • Verify that with this build after PT Run start icons and author are properly updated

Quality Checklist

  • Linked issue: [Run Plugin Manager] Missing Icons #14826
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@davidegiacometti davidegiacometti added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Plugin Manager Issues with the PowerToys Run plugin manager labels Dec 4, 2021
@htcfreek
Copy link
Collaborator

htcfreek commented Dec 4, 2021

@davidegiacometti
For me it was broken since 0.51.0.

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no harm in this change.
LGTM!
Thank you for the contribution.

@jaimecbernardo jaimecbernardo merged commit 3b89e6f into main Dec 6, 2021
@davidegiacometti davidegiacometti deleted the users/davidegiacometti/issue-14826 branch December 6, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Plugin Manager Issues with the PowerToys Run plugin manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants