Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings] Sort Languages ComboBox #35462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Settings] Sort Languages ComboBox #35462

wants to merge 1 commit into from
+31 −7

Conversation

davidegiacometti
Copy link
Collaborator

Summary of the Pull Request

Sort the languages ComboBox keeping the default on top.

PR Checklist

Detailed Description of the Pull Request / Additional comments

The importance of using StringComparison.CurrentCultureIgnoreCase can be noted using Portuguese.

image

Validation Steps Performed

Tested using PowerToys.Settings.pri from the latest stable build.

  • Verified that the languages in the ComboBox are sorted with the default on top
  • Switched multiple languages
  • Verified that the UI and language.json are in sync

@davidegiacometti
Copy link
Collaborator Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidegiacometti