Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quick Accent] Select multiple languages #21261

Open
htcfreek opened this issue Oct 15, 2022 · 24 comments
Open

[Quick Accent] Select multiple languages #21261

htcfreek opened this issue Oct 15, 2022 · 24 comments
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-Quick Accent Refers to the Quick Accent PowerToy Status-In progress This issue or work-item is under development Tracker Issue that is used to collect multiple sub-issues about a feature

Comments

@htcfreek
Copy link
Collaborator

Description of the new feature / enhancement

Currently you can select "All available" or a specific language. It would be helpful and nice if you can select multiple languages to have more than one but not all of them. For example, German and Currency.

Scenario when this would be used?

When you need only some of the languages.

Supporting information

No response

@htcfreek htcfreek added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Product-Quick Accent Refers to the Quick Accent PowerToy Idea-Enhancement New feature or request on an existing product labels Oct 15, 2022
@joosniz
Copy link

joosniz commented Oct 30, 2022

Having to go through all the "Quick" Accents when you just need two or three languages makes the name a little ironic, wouldn't you say? 😉 Here's a couple options for the implementation I can think of off the top of my head.

Option 1. A checkbox list. Perhaps the simplest solution.

Option 2. An input field with suggestions where you can add languages as if they are tags. Type "sp" and see Spanish in the list, select the result to add it to the field. It gets added as a tag that you could remove with a small X button. Press the field to see all languages, and select another langue to add that one as a tag as well.

@marqustd
Copy link

marqustd commented Nov 9, 2022

This one would be really nice. I need only Polish and Swedish, looking for a specific letter among 7 very similar is quite frustrating...

@seatrout
Copy link

Can I add my support for this? I use Swedish, German, and French. and have no use for the vast majority of the suggestions offered for many vowels. On the other hand, when I limit the selection to Swedish, there are a couple of letters missing (é and ü) which, though rare, certainly are used sometimes (I had a boss called Krüger when I lived there)

@antondd
Copy link

antondd commented Jan 13, 2023

I find the new feature "sort by usage frequency" helps already to get the characters used to the first positions, but yes, selecting only the needed languages (for me German and French) would be the best solution.

@htcfreek
Copy link
Collaborator Author

htcfreek commented Dec 10, 2023

I support this enhancement. I would like to try to work on this. Though before starting is this something we want to add, i.e. would the UX for this work?

Originally posted by @SKPG-Tech in #30320 (comment)

@SKPG-Tech
Great to hear. (For your information I have deduplicated all issues against this here. So this issue is the new tracking issue.)

Feel free to start work on it and open a PR. This will be a great enhancement. I can imagine to have a checklist of all available languages with a "uncheck/check all" button on the settings page.

If you have any questions or need any help please don't worry to ask.

@CarlGao4
Copy link

Is it possible to add custom charsets?

@htcfreek
Copy link
Collaborator Author

htcfreek commented Dec 11, 2023

Is it possible to add custom charsets?

@CarlGao4
It should be. But your request is tracked in #20312.

@SKPG-Tech
Copy link

@htcfreek I've found this in the Community Toolkit, do you think it would fit the requirements? I think it is better than having a list of checkmarks

ApplicationFrameHost_sUVBA6C8tW

@SKPG-Tech
Copy link

Sorry, I'm resigning from this. If anyone wants to do this, go right ahead.

@SKPG-Tech SKPG-Tech removed their assignment Feb 27, 2024
@Jay-o-Way Jay-o-Way removed the Status-In progress This issue or work-item is under development label Mar 10, 2024
@catwithbanana
Copy link

Chiming in to agree with the need for this feature. My only option for covering all of the characters I need right now is to select "All available," which creates an absolute mess of characters. The ability to select multiple languages or arbitrary character lists is badly, badly needed.

@echeifet33
Copy link

As a note as to why this is really needed, I just updated PowerToys so now a bunch of new language sets have been added for me. When I QuickAccent for "e" on my laptop, the bar doesn't fit on my screen. I can't see my most frequently used accents as they get cut off! If I could remove the Hebrew vowels or some of the Latin accents, this would not be an issue.

@X-shoucheng
Copy link

And anyone are still working on the feature?
I especially hope this feature can be done.

@albertvaka
Copy link

+1. I type in 3 non-English languages, so I have to resort to the very broad "all available" character sets option, while really I would only need a few extra characters.

@PesBandi
Copy link
Contributor

Hello everyone, in case someone intends to work on this I want to suggest using a wrap panel instead of a list view, considering the large number of languages.
image

@SpaceWarriorR
Copy link

Really hoping someone manages to make this change, it would be really useful.

@htcfreek
Copy link
Collaborator Author

Hello everyone, in case someone intends to work on this I want to suggest using a wrap panel instead of a list view, considering the large number of languages.
image

@PesBandi
Wondering if you like to work on it?

I like your suggestion.

And for logical reasons I wonder if we should update All available to "special cgaracters" so that this only includes the characters that does not match to any other category. (Because selecting all checkboxes including an "all character sets" category that is not really the sum of all other sets feels odd.)

@PesBandi
Copy link
Contributor

PesBandi commented Jul 4, 2024

Hello @htcfreek, sorry for the late response.

And for logical reasons I wonder if we should update All available to "special cgaracters"

Yes of course, I just didn't notice it when I changed the ComboBoxItems to CheckBoxes.

Wondering if you like to work on it?

I didn't intend to, but I can look into it. I am not confirming that I will complete it in a reasonable amount of time, but there's a chance I might (if I have some free time). If anyone else wants to work on this feel free to do so.

Also another thing I realized, CheckBoxes probably aren't the best idea. The ViewModel code for 38 CheckBoxes would be pretty long. I suggest using a CheckedListBox.

@KWodarczyk
Copy link

I suggested adding "Apply" button as well, more info here microsoft/microsoft-ui-xaml#263 (comment)

@OscBacon
Copy link

OscBacon commented Nov 6, 2024

So, the checkboxes would need to be added to this file?
https://github.com/microsoft/PowerToys/blob/main/src/settings-ui/Settings.UI/SettingsXAML/Views/PowerAccentPage.xaml

And then allow the power accents value to be an array instead of one string?

https://github.com/microsoft/PowerToys/blob/main/src/settings-ui/Settings.UI/ViewModels/PowerAccentViewModel.cs

A checkbox that says "All available" could work too, checked by default, and when unchecked lists all of the languages to be checked individually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-Quick Accent Refers to the Quick Accent PowerToy Status-In progress This issue or work-item is under development Tracker Issue that is used to collect multiple sub-issues about a feature
Projects
Status: No status
Development

No branches or pull requests