-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PowerRename] New Fluent UI is less screen space efficient #14164
Comments
I hate the new design. The old window was simple and easy to use. There should at least be a way to revert back as the original-update window on the right makes it look like it already happened. |
Cc: @niels9001 |
Thanks for the feedback! WinUI Large default window size Datagrid and lack of column resizing All of this hopefully explains some of the decisions that were made in the development process. I think this feedback is very valuable to make sure we test it on different resolutions and setups. And also @Zenrin's feedback on the position of the Apply button. In the past, I have made a quick mock-up of what a 'vertical' UI would look like. @dori4n @Zenrin any thoughts on that? |
So, neils9001, what you're saying is the the sucky over-large and visually wasteful UI is what we're stuck with, because MS says so. Wonderful. MS hasn't had decent ui design since Win7. The old renamer ui was by far superior to the current hot mess. An additional whine: Where is the count of selected/change files? Can't find it. Needs to be there. |
I think a density setting with "compact" would be the best solution for this, which would decrease paddings, margins and other spacing. At least a compact mode for lists and such, those are long and being able to see a lot is very practical. |
UI controls are large so that you can use them with a touch screen. |
@whawm1 Let's keep the feedback constructive, please. There were a lot of accessibility issues flagged with the old UI, and there was no dark/light mode support or support for touch + pen. Additionally, it looked kind of dated. More info here: #888 One of the goals of these UI changes for PowerToys is that these utilities 'should do its best to look like a system level integration' (see #891). Since PowerToys only runs on recent version of Windows 10 and 11, it makes sense to revamp the UI to reflect the changes Microsoft introduced for Windows. Agree on the selected/change files - I'd suggest to file a new issue so it can be tracked. |
That's generally not a good argument to make for changing things. Change for the sake of change, or, secondarily for visual appeal, where it impacts the usefulness of a tool, is not good change.
Theming and touch controls are also supported by the native Win32 controls, but unlike the new WinUI controls that evolved from the "Metro UI" controls for Windows Phone 7.x+, "modern apps" and the Universal Windows Platform, they're not huge and unwieldy unless the user's system is configured for such a thing.
That was the most striking first impression of the change, everything was huge. The 10-20% size difference may apply to the font sizes, but when you also account for the padding and margins, it's more like 50-60%. That's like turning the DPI scaling factor to 150%+ from the control panel.
I have since noticed that. And that's a breaking change for me. I need the ability to resize the window and the preview columns when I am renaming files with very long names. I would even argue, that dealing with very long file names is a key feature of a tool like this, and where this software should shine and excel but now no longer can.
The layout shown on the right is definitely much better, since there is more space to show a long search and/or replacement string now. But if the columns for the match/result preview cannot be resized with the window, it doesn't help all that much. |
Based on the various conversations I've read, I'm certain nobody at Microsoft cares, but -- yeah, this new PowerRename UI is basically unusable. Even if you discount the massively less efficient use of screen space (which shouldn't be discounted, but...), it's SLOW with any significant number of files, it's much harder to figure out what's going on, the scrollbar is tiny to the point of unusability (I should not need to spend multiple seconds of precision mousing just to be able to grab it!), and the lack of resizable columns -- regardless of the cause, even if it's a problem "upstream" -- utterly break's the tool's primary purpose for existing in many situations. I get the idea of wanting to standardize on the new user interface (really, I do, even if I personally don't generally like the new UI), but holy cow you should not be sacrificing this much usability so that you can check off the checkbox that says "uses new UI". This is not far from sealing a server in concrete and throwing it in the ocean in the name of "security" -- sure, you get to check off that checkbox, but that stops mattering if the cost is "most of the usable functionality". The purpose of software is to serve the user, not to serve UIs or software libraries. When a change makes usability suffer this much, to the point that a bunch of users are rolling back to previous versions just so they can use the tool (and I'm going to be one of them here in a few minutes), it's the wrong change to make, even if it does make the UI "more standard". None of the touted benefits ("more standard", "better for touch users", etc) offsets the reality that the tool is now far less able to do its job. Please don't prioritize UI dogma over the actual functionality of the software, at least to this extreme. You can always switch back to the new UI in the future, when the building blocks for it are less fundamentally broken. |
@alinsavix Thanks for the extensive feedback. I think these are valid concerns. Performance: this is something that should (hopefully) be resolved with moving to WinUI 3 (instead of XAML Islands like we currently do). Draggable columns: this is bit of a blocker for now since this control is not part of WinUI. However, with #14164 (comment) we can be a bit more flexible and maybe add an additional scroll viewer to make horizontal scrolling better. Layout and spacing: I think #14164 (comment) might be an upgrade and might take some of these pain points away. Additionally, some of the margins / paddings can be finetuned there as well. Do you agree? |
@niels9001 @dori4n I like the new mockups much better as it helps provide a better flow to the window like it did before. Much likely having to do with where the apply button resides underneath the original/renamed list. |
@dedavis6797 @crutkas Do you agree moving to the UI proposal on the right (see image below)? I can take this up since it's an easy change. This might help simplifying the XAML for the pseudo-datagrid as well which will help performance |
I think switching to the proposed UI makes sense, and perf improvements for renaming many files are in the works. We've identified the potential bottleneck and are working on a solution. |
I'd want remind people here, we say, "Little by Little" a lot with PowerToys. We tend to ship
|
Also to boil the root of the issue is this, correct? @dori4n
|
@stefansjfw and I have worked on updating the UI and making it more performant. Due to virtualization issues the current version was having major performance issues. That is now resolved luckily. On the UI front, I have been looking at the proposed vertical layout. However, in testing, the visual hierarchy of the layout was pretty poor. And as @crutkas pointed out, it would limited logical screen real estate for any future new features to be added into the UI. Lastly, putting in some of the horizontal checkboxes gave us major issues with localization (e.g. Dutch or German text labels can be quite extensive. Therefore, the proposal is to stick with the current layout. However, the margins, paddings and font-sizes have been tweaked based on the feedback of you all. As you can see we can fit in more items by default in the grid. Things that have changed:
Here's a visual comparison between v1 and v2. |
Reducing all that whitespace between lines is important. I didn't buy a 4K 43" monitor to see less text on the screen. I like seeing 150 lines fit at once. People who don't can adjust their DPI scaling. But having the PowerRename window open to 80% the size of my 43" monitor every time is inexcusable. At least have it remember the size/position that I leave it in for the next time it opens. |
@tjdennis Yes, the default width/height should be smaller in the upcoming update. Once we move to WinUI3 we can hopefully enable auto-resizing (based on content) and remember window position by default. @PaulCoddington Hmm strange - seems to go something wrong since in your screenshot Windows uses the dark theme and PowerRename uses the light theme? Does switching themes in Windows settings resolve the issue? |
Formatting buttons are displayed in Dark Mode, but not in Light Mode or Custom (dark desktop with light apps). Action buttons seem broken in all modes. Just noticed the new Windows Store has a similar problem. The Update apps button is a blank white square, and a large space at the top of every page is "blank" (white text on near white background). Perhaps there is a problem with WinUI 3 apps in general on Windows 10 21H1/H2? I routinely run in Custom mode (classic Win10 theme) with dark desktop and light apps, because black text on white page is better for my eyes when coding (dark mode text "glows" like a lightbulb on a calibrated monitor) and I need a dark neutral background for graphics work and photo editing. But, there is no theme mode which works, even though some problems may resolve with theme settings they do not resolve 100%. |
Thanks, Paul for the detailed description. Yeah, it seems to be a Windows and/or WinUI issue. Over at the WinUI repo a similiar issue has emerged, I think it's pretty similiar? Link: |
This is fixed in 0.51. Please head over to our releases and get the update! https://aka.ms/installpowertoys |
I updated PowerToys from v0.48 to v0.49.1 yesterday after having been nagged about an update being available and noticed today, that upon starting PowerRename to rename 20 files at once, that the user interface window was extremely large, the spacing between individual lines in the list view much larger than the actual text lines themselves and that the overall layout of user elements had significantly changed in a manner that makes using the application much less practical. I have traced the change back to #13028 through a quick search, and from there was lead to #13678 and #888. While the update does include some minor quality of life improvements like RegEx auto-completion, dark-mode, and enhanced accessibility features are nice for those who need them, the overall result is worse, especially on small screens.
The text was updated successfully, but these errors were encountered: