-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for milestones #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I've noted some requested changes for you to make.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good update. Minor issues remaining.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. Minor changes requested. Will be interested in hearing from @danbelcher-MSFT as well.
$existingMilestone.title | Should be $defaultMilestoneTitle1 | ||
} | ||
|
||
It "Should have the expected state" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My nitpick here is that these test names are generic and so don't tell you anything about what is actually being tested. When you run the tests, you should see:
For creating a new milestone:
...
'Should be in the closed state'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Can you please get this branch up-to-date with what's in master? There are currently conflicts preventing the merge. |
@HowardWolosky I had merged master into this branch before you made that conflicts comment, and I'm not seeing any conflicts anymore. The only thing blocking the merge now is that "The base branch restricts merging to authorized users" and I'm not authorized. I assume you are able to merge the PR? |
Thanks -- issue was on my end. GitHub was saying that I couldn't |
Added functionality for the milestones api