Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for issue labels #59

Merged
merged 18 commits into from
Dec 13, 2018

Conversation

joseartrivera
Copy link
Contributor

Added functionality for the issue label APIs

GitHubLabels.ps1 Outdated Show resolved Hide resolved
danbelcher-MSFT
danbelcher-MSFT previously approved these changes Dec 4, 2018
GitHubLabels.ps1 Outdated Show resolved Hide resolved
Tests/GitHubLabels.tests.ps1 Outdated Show resolved Hide resolved
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I've noted some requested improvements.

GitHubLabels.ps1 Outdated Show resolved Hide resolved
GitHubLabels.ps1 Outdated Show resolved Hide resolved
GitHubLabels.ps1 Show resolved Hide resolved
GitHubLabels.ps1 Outdated Show resolved Hide resolved
GitHubLabels.ps1 Show resolved Hide resolved
GitHubLabels.ps1 Outdated Show resolved Hide resolved
GitHubLabels.ps1 Outdated Show resolved Hide resolved
GitHubLabels.ps1 Outdated Show resolved Hide resolved
GitHubLabels.ps1 Outdated Show resolved Hide resolved
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting on the other requested PR changes as well.

GitHubLabels.ps1 Show resolved Hide resolved
GitHubLabels.ps1 Outdated Show resolved Hide resolved
GitHubLabels.ps1 Outdated Show resolved Hide resolved
Tests/Config/Settings.ps1 Outdated Show resolved Hide resolved
Tests/GitHubLabels.tests.ps1 Outdated Show resolved Hide resolved
Tests/GitHubLabels.tests.ps1 Outdated Show resolved Hide resolved
Tests/GitHubLabels.tests.ps1 Outdated Show resolved Hide resolved
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback for you to consider.

GitHubLabels.ps1 Outdated Show resolved Hide resolved
GitHubLabels.ps1 Outdated Show resolved Hide resolved
GitHubLabels.ps1 Outdated Show resolved Hide resolved
GitHubLabels.ps1 Outdated Show resolved Hide resolved
GitHubLabels.ps1 Outdated Show resolved Hide resolved
GitHubLabels.ps1 Outdated Show resolved Hide resolved
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@HowardWolosky HowardWolosky merged commit 6c73554 into microsoft:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants