-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/GitHub codespaces organization #416
base: master
Are you sure you want to change the base?
Feature/GitHub codespaces organization #416
Conversation
- Stop-GitHubCodespace - Wait-GitHubCodespaceAction
Co-authored-by: Howard Wolosky <[email protected]>
Co-authored-by: Howard Wolosky <[email protected]>
not howard Co-authored-by: Howard Wolosky <[email protected]>
Co-authored-by: Howard Wolosky <[email protected]>
Co-authored-by: Howard Wolosky <[email protected]>
Please review, @HowardWolosky. |
TypeName assertions resolved. Any other feedback, @HowardWolosky? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those updates. Looks just about there. I'll kick off a validation run to see if I missed anything else.
@@ -769,11 +920,22 @@ filter Stop-GitHubCodespace | |||
GitHub Apps must have write access to the codespaces_lifecycle_admin repository permission to use this endpoint. | |||
#> | |||
[CmdletBinding( | |||
DefaultParameterSetName = 'AuthenticatedUser', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference here would be to avoid ambiguous code. As a code reader, it took too much time for me to look at what's here and parse out what might be happening. A comment could probably address that, but even better would simply be having the code be declarative on intention. In this specific scenario, this could be resolved by augmenting the $CodespaceName
declaration to be part of two different parametersets, and then having the default one be one that's actually defined.
[Parameter(
Mandatory,
ValueFromPipeline,
ValueFromPipelineByPropertyName,
ParameterSetName = 'Organization')]
[Parameter(
Mandatory,
ValueFromPipeline,
ValueFromPipelineByPropertyName,
ParameterSetName = 'AuthenticatedUser')]
[string] $CodespaceName,
/azp run PowerShellForGitHub-CI |
Co-authored-by: Howard Wolosky <[email protected]>
$null = Invoke-GHRestMethod @params Co-authored-by: Howard Wolosky <[email protected]>
…erset for readability
Please review again, @HowardWolosky. |
@HowardWolosky 8 months!? Your resource management policy seems a bit biased. |
Description
Add outstanding support for Codespaces organizations and Codespaces machines.
Issues Fixed
References
Codespaces/organizations
Codespaces/machines
Checklist