Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set-GitHubRepository: Add Support for 'Web Commit Signoff Required' Option #389

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Set-GitHubRepository: Add Support for 'Web Commit Signoff Required' Option #389

merged 3 commits into from
Feb 27, 2023

Conversation

X-Guardian
Copy link
Contributor

Description

This PR adds the WebCommitSignoffRequired parameter to the Set-GitHubRepository function:

Issues Fixed

References

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Formatters were created for any new types being added.
  • New/changed code continues to support the pipeline.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

@X-Guardian X-Guardian changed the title Initial commit Set-GitHubRepository: Add Support for 'Web Commit Signoff Required' Option Jan 11, 2023
@X-Guardian
Copy link
Contributor Author

@HowardWolosky, this PR is ready for review.

HowardWolosky
HowardWolosky approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight-forward change. Thanks

@HowardWolosky HowardWolosky added the Merge Pending CI This PR is ready to merge once CI has completed running on it. label Feb 27, 2023
@HowardWolosky
Copy link
Member

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky HowardWolosky removed the Merge Pending CI This PR is ready to merge once CI has completed running on it. label Feb 27, 2023
@HowardWolosky HowardWolosky merged commit 516be0b into microsoft:master Feb 27, 2023
@X-Guardian X-Guardian deleted the WebCommitSignoffRequired branch April 19, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HowardWolosky HowardWolosky HowardWolosky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set-GitHubRepository: Add Support for 'Web Commit Signoff Required' Option
2 participants
@X-Guardian @HowardWolosky