-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Build updates: build queuing and Windows PS7 #260
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the CI build with two new features: 1. Validation against Windows PS7 (PowerShell Core) This pipeline previously had three platforms that it tested against: * Windows PS5 * Linux PS7 (PowerShell Core) * macOS PS7 (PowerShell Core) With this change, we add a fourth plaform: Windows PS7 (PowerShell Core) 2. Build queuing The unit tests operate against live GitHub accounts (as opposed to mocking out the execution of the API calls). Each platform has its own account that it operates against to alllow each platform to be tested in parallel. However, if more than one build is queued at once, then the tests can start to stomp over the expected state in the tests accounts. This new change adds a new `job` that will essentially create a "queue" of running builds, only allowing them to start to run once all previously queued builds have completed.
HowardWolosky
added
the
build
Changes related to the build infrastructure for the project.
label
Jul 1, 2020
/azp run PowerShellForGitHub-CI |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run PowerShellForGitHub-CI |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run PowerShellForGitHub-CI |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run PowerShellForGitHub-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run PowerShellForGitHub-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run PowerShellForGitHub-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the CI build with two new features:
Validation against Windows PS7 (PowerShell Core)
This pipeline previously had three platforms that it tested against:
Windows PS5
Linux PS7 (PowerShell Core)
macOS PS7 (PowerShell Core)
With this change, we add a fourth platform:
Windows PS7 (PowerShell Core)
Build queuing
The unit tests operate against live GitHub accounts (as opposed to mocking out the execution of the API calls). Each platform has its own account that it operates against to alllow each platform to be tested in parallel. However, if more than one build is queued at once, then the builds can start to stomp over the expected state in the tests accounts. This change adds a new
job
to the pipeline which will create a "queue" of running builds by only allowing a build to continue processing once all previously queued builds have completed.Issues Fixed
References
https://developercommunity.visualstudio.com/idea/365730/prevent-parallel-execution-of-the-same-build-defin.html
Checklist
New/changed code continues to support the pipeline.Changes to the manifest file follow the manifest guidance.Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.Relevant usage examples have been added/updated in USAGE.md.If desired, ensure your name is added to our Contributors list