Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHubBranches: Add New/Remove-GitHubRepositoryBranch Functions #256

Merged
merged 25 commits into from
Jul 16, 2020
Merged

GitHubBranches: Add New/Remove-GitHubRepositoryBranch Functions #256

merged 25 commits into from
Jul 16, 2020

Conversation

X-Guardian
Copy link
Contributor

Description

This PR adds the following functions to the GitHubBranches module:

  • New-GitHubRepositoryBranch
  • Remove-GitHubRepositoryBranch

Issues Fixed

None

References

GitHub Repos API

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

X-Guardian added 18 commits June 29, 2020 17:59
@X-Guardian
GitHubRepositryChanges:
05a06ae 
- Add New-GitHubRepositoryBranch and Remove-GitHubRepositoryBranch
@X-Guardian
Update review comments
41ad7db
@X-Guardian
Fix Get-GitHubRepositoryBranch Exception handling
17cbc5c
@X-Guardian
Add GitHubBranches tests
02e018e
@X-Guardian
Fix GitHubBranches tests
ea23414
@X-Guardian
GitHubBranches updates
e90e6f2 
- Add CBH Inputs
- Fix CBH Outputs
- Add PositionalBinding
- Change Mandatory parameter order
- Add Invocation parm to Write-InvocationLog
- Fix getGitHubRepositoryBranchParms
- Add temp code to handle diffs in exception object between PS5 & PS7
- Add ShouldProcess to Remove-GitHubRepositoryBranch
@X-Guardian
Added Remove-GitHubRepositoryBranch -Force Switch
953a902
@X-Guardian
Update -Force parameter processing.
89c2325
@X-Guardian
Fix formatting
eb35376
@X-Guardian
Update USAGE.md
996fb56
@X-Guardian
Remove redundant Invocation parameter
31ee9ef
@X-Guardian
Update Remove-GitHubRepositoryBranch examples
8dd123e
@X-Guardian
Update force condition
9a49944
@X-Guardian
Remove duplicate AfterAll block in tests.
efebcfb
@X-Guardian
Add pipelining support
884290e
@X-Guardian
Update tests for StrictMode v1.0
a1d7514
@X-Guardian
Fix review comments
65edf9f
@X-Guardian
Update Usage.md
67d8be1
@X-Guardian X-Guardian mentioned this pull request Jun 29, 2020
Closed
8 tasks
@HowardWolosky HowardWolosky added api completeness This is basic API functionality that hasn't been implemented yet. api-refs Work to complete the API's defined here: https://developer.github.com/v3/git/refs/ labels Jun 29, 2020
@X-Guardian
Copy link
Contributor Author

I think it probably makes more sense to allow #97 to go in, and then have this function be a wrapper on top of New-GitHubReference. You can still make this an intelligent helper that can automate retrieving the sha via an internal call to Get-GitHubRepositoryBranch when it hasn't been passed in manually or via the pipeline, but given that we'll want New-GitHubReference in the module anyway to be able to support tag references, it seems like it makes more sense to not duplicate the logic of forming a call to create new references across two functions. Same for Remove-*.

If #97 is still a little way to being complete, how about merging this as-is and then converting it to use the reference function when it is available?

@X-Guardian X-Guardian marked this pull request as ready for review June 29, 2020 17:03
@HowardWolosky
Copy link
Member

If #97 is still a little way to being complete, how about merging this as-is and then converting it to use the reference function when it is available?

Totally reasonable idea. I'll read through this again in that light for any additional feedback, and if there isn't any, will get it merged in soon.

HowardWolosky
HowardWolosky requested changes Jul 1, 2020
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's pretty close to merging in.
Just a few more things to touch up.
Thanks!

GitHubBranches.ps1 Show resolved Hide resolved
GitHubBranches.ps1 Outdated Show resolved Hide resolved
GitHubBranches.ps1 Show resolved Hide resolved
GitHubBranches.ps1 Outdated Show resolved Hide resolved
GitHubBranches.ps1 Outdated Show resolved Hide resolved
Tests/GitHubBranches.tests.ps1 Outdated Show resolved Hide resolved
Tests/GitHubBranches.tests.ps1 Outdated Show resolved Hide resolved
Tests/GitHubBranches.tests.ps1 Outdated Show resolved Hide resolved
Tests/GitHubBranches.tests.ps1 Outdated Show resolved Hide resolved
Tests/GitHubBranches.tests.ps1 Outdated Show resolved Hide resolved
@HowardWolosky HowardWolosky added the waiting for update Waiting for an update to the PR before the next review label Jul 1, 2020
@HowardWolosky HowardWolosky mentioned this pull request Jul 7, 2020
Closed
HowardWolosky
HowardWolosky requested changes Jul 7, 2020
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple things I missed before.

GitHubBranches.ps1 Outdated Show resolved Hide resolved
GitHubBranches.ps1 Show resolved Hide resolved
GitHubBranches.ps1 Outdated Show resolved Hide resolved
GitHubBranches.ps1 Show resolved Hide resolved
HowardWolosky
HowardWolosky approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this!

@HowardWolosky
Copy link
Member

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky HowardWolosky removed the waiting for update Waiting for an update to the PR before the next review label Jul 16, 2020
@HowardWolosky HowardWolosky merged commit d76f54b into microsoft:master Jul 16, 2020
@X-Guardian X-Guardian deleted the GitHubBranches-NewRemove branch April 19, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HowardWolosky HowardWolosky HowardWolosky approved these changes

Assignees
No one assigned
Labels
api completeness This is basic API functionality that hasn't been implemented yet. api-refs Work to complete the API's defined here: https://developer.github.com/v3/git/refs/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@X-Guardian @HowardWolosky