Adding functionality for Project Columns #162
Conversation
There was a problem hiding this comment.
Once again, this is awesome. Thanks for the contribution. There are a few changes in here that I'd like you to make before we merge this in (after we merge in the project core work).
Additionally, I'd encourage you to think up some suggested Project usage examples that could be added to USAGE.md.
GitHubProjectColumns.ps1
Outdated
| Moves the project column with id 999999 to the Last position. | ||
|
|
||
| .EXAMPLE | ||
| Move-GitHubProjectColumn -Column 999999 -Position After:888888 |
There was a problem hiding this comment.
This syntax should be abstracted away from users.
I see two options here (maybe you see more):
- Have three mutually exclusive parameters:
[switch] $First,[switch] $Last,[int64] $After, and add some error checking into the body to ensure that you either have$truefor$Firstor$Last(since a user could pass in-First:$false), or a positive value for$After. Then build the appropriate body value from that. - Have a
ValidateSetwith the options of First, Last, After, and then an additional parameter of[int64] $Afterand in-body validation that$Afteris only suppliedif ('after' -eq $Position).
I think the first option is cleaner. I'm open to other suggestions. I just don't like users having to come up with the After:888888 syntax themselves. #Closed
There was a problem hiding this comment.
Totally agree. Thanks for the feedback, went ahead with option one. #Closed
There was a problem hiding this comment.
Also - wondering if I should be clicking the resolve button when I fix it? Or should that be for you to resolve, once you review the adds?
Sorry if I'm doing this wrong! #Closed
HowardWolosky
added
api completeness
|
Awesome! Where do the tests run? Is that the 'Microsoft.PowerShellForGitHub' task that shows as expected? |
|
In theory, yes. Those will fail right now however for two reasons:
I'll be running them manually for validation before merging, once the Core changes are in. |
|
Great - thanks for the explanation! I believe I have the core changes have been made and are ready for you. |
|
Looks like GitHub's web merge conflict resolver messed with the whitespace in the .psd1 file. Can you take a look and get that fixed up? (Here and in the project cards PR as well)? |
I'm not sure what you mean by that, I pulled down the changes and the whitespace all looks ok... e.g.:
|
|
You'll see the problem if you look at the "Files Changed" tab.
|
|
I'm sorry - I'm still not following, if I look at the file it all looks lined up. I do see that it seems to think all the lines have changed, but I don't see why. |
Exactly. That's what we want to avoid, because it destroys the ability to diff and clearly see what changed in the file. Some sort of whitespace changed in it, but I can't tell what. It doesn't appear to be the spaces themselves, nor the linefeeds. The simplest way forward at this point I believe would be to copy the content that's currently in master, commit that (which would remove your changes), and then re-apply the changes you made and commit that again. (Don't do it in one go because git may not notice the whitespace change and may perceive the file as not changed at all). |
|
Ahh!! Gotcha! |
|
This is now available publicly in 0.12.0. Thanks so much for your contribution. 🎆 |
|
Yes! This is great, thanks so much for all your coaching! |
Covers:
The tests don't run successfully without the Project code from PR #160, if you want I can rebase this branch with master once/if the core project code gets merged in?