-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix api url for Github Enterprise #117
Comments
Actually, after you saying that not all enterprise installations have the API available at |
hmm I thought all Github enterprise instances had a different api url than the public github.com. This has been the case in my current setup as well as the last place I worked. Are you saying that there are some github enterprise instances that are accessible at : https://developer.github.com/enterprise/2.16/v3/#current-version |
To my knowledge both API endpoints work with a strong preference from GitHub support for the api.(domain) endpoint. We have seen integrations using either one to no ill effect. If your deployment doesn't expose api.(domain) that's usually a sign of a configuration issue. You can confirm the subdomain isolation configuration settings in the management console. https://help.github.com/enterprise/2.1/admin/articles/configuring-dns-ssl-and-subdomain-settings |
Per the [documentation](https://developer.github.com/enterprise/2.16/v3/#current-version), enterprise installations support a base URL of `http(s)://[hostname]/api/v3` in addition to the existing support of `http(s)://api.[hostname]/`. This PR updates the module to _always_ use the `http(s)://[hostname]/api/v3` syntax when `[hostname]` is _not_ `github.com`. Fixes #117
The api url has been coded in the following format:
While this works for github it fails with the enterprise version because the api url is different:
As a result when you call any of the function referencing Github enterprise you may get the following error:
Will raise a PR to fix this.
The text was updated successfully, but these errors were encountered: