Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Release support #110

Closed
rjmholt opened this issue May 20, 2019 · 2 comments · Fixed by #177
Closed

GitHub Release support #110

rjmholt opened this issue May 20, 2019 · 2 comments · Fixed by #177
Labels
api completeness This is basic API functionality that hasn't been implemented yet. help wanted Anyone in the community is welcome to do this work up for grabs Anyone in the community is welcome to do this work

Comments

@rjmholt
Copy link
Contributor

rjmholt commented May 20, 2019 •
edited
Loading

I wrote some PowerShell to publish a GitHub release recently (here) and was wondering if you would like it? It needs changing to work with the conventions of this module, of course, but with some guidance I can do that.

Let me know if you're interested. I haven't exposed any other GitHub Release API support, but could relatively easily.
@HowardWolosky
Copy link
Member

Go for it. Would love to have it.
It also might be worthwhile to see if vscode-powershell could depend on this module for the GitHub integration functionality, as opposed to maintaining two implementations trying to do the same thing, one more generally than the other...

@HowardWolosky HowardWolosky added api completeness This is basic API functionality that hasn't been implemented yet. help wanted Anyone in the community is welcome to do this work up for grabs Anyone in the community is welcome to do this work labels May 20, 2019
@HowardWolosky HowardWolosky mentioned this issue May 20, 2019
Open
80 tasks
@rjmholt
Copy link
Contributor Author

rjmholt commented May 20, 2019

It also might be worthwhile to see if vscode-powershell could depend on this module for the GitHub integration functionality, as opposed to maintaining two implementations trying to do the same thing, one more generally than the other...

Yes that's my thinking too

@jschpp jschpp mentioned this issue Jul 25, 2019
Closed
@smaglio81 smaglio81 mentioned this issue Jul 26, 2019
Merged
HowardWolosky pushed a commit that referenced this issue Sep 18, 2019
@smaglio81 @HowardWolosky
Adding Get-GitHubRelease (#125)
7ea773c 
Similar to #110, I needed some functionality around releases. I didn't so much need functionality to publish a release, but I needed to retrieve the list of releases that we're published. So, this is just a function for Get-GitHubRelease.
@HowardWolosky HowardWolosky mentioned this issue May 22, 2020
Merged
8 tasks
HowardWolosky added a commit that referenced this issue Jul 20, 2020
@HowardWolosky
Complete support for Releases API (#177)
356af2f 
This completes the required work to support the set of Releases API's.

It adds the following functions:

* `New-GitHubRelease`
* `Set-GitHubRelease`
* `Remove-GitHubRelease`
* `Get-GitHubReleaseAsset`
* `New-GitHubReleaseAsset`
* `Set-GitHubReleaseAsset`
* `Remove-GitHubReleaseAsset`

`Invoke-GHRestMethod` has been updated to be able to upload a file (via the new `InFile` parameter) and download a file (via the `Save` switch which will cause it to return back a `FileInfo` object of a temporary file which can then be renamed as seen fit by the caller).

This also adds formatters for `GitHub.Release` and `GitHub.ReleaseAsset`.

Positional Binding has been set as `false` for the three functions, and `Position` attributes added to the function's mandatory parameters.

Reference: [GitHub Releases](https://developer.github.com/v3/repos/releases/)


Fixes #47 
Fixes #110
@HowardWolosky HowardWolosky mentioned this issue Jul 21, 2020
Merged
9 tasks
@tigerfansga tigerfansga mentioned this issue Apr 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api completeness This is basic API functionality that hasn't been implemented yet. help wanted Anyone in the community is welcome to do this work up for grabs Anyone in the community is welcome to do this work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Complete support for Releases API HowardWolosky/PowerShellForGitHub
2 participants
@rjmholt @HowardWolosky