Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make telemetry reporting not require NuGet downloads #104

Closed
HowardWolosky opened this issue Apr 11, 2019 · 0 comments · Fixed by #186
Closed

Make telemetry reporting not require NuGet downloads #104

HowardWolosky opened this issue Apr 11, 2019 · 0 comments · Fixed by #186
Assignees
@HowardWolosky
Labels
enhancement An issue or pull request introducing new functionality to the project. in progress Work on this issue is already underway. Please don't work start new work on it.

Comments

@HowardWolosky
Copy link
Member

Right now, in order for telemetry to work, 3 NuGet packages need to be downloaded (or cached):

  • Microsoft.ApplicationInsights (for Microsoft.ApplicationInsights.dll)
  • Microsoft.Diagnostics.Tracing.EventSource.Redist (for Microsoft.Diagnostics.Tracing.EventSource.dll)
  • Microsoft.Bcl.Async (for Microsoft.Threading.Tasks.dll)

In the end, the telemetry events are just being sent as web requests. While the web request format isn't documented, it should be possible to reverse-engineer via a tool like Fiddler.

If we can figure out how to make those web requests directly, then we can improve the first-run experience for users to not need to have that initial binary download.
@HowardWolosky HowardWolosky added enhancement An issue or pull request introducing new functionality to the project. up for grabs Anyone in the community is welcome to do this work help wanted Anyone in the community is welcome to do this work good first issue If you're new to the project (or to OSS in general) and you'd like to contribute, try this one. labels Apr 11, 2019
@HowardWolosky HowardWolosky mentioned this issue Apr 11, 2019
Closed
@HowardWolosky HowardWolosky self-assigned this Apr 11, 2019
HowardWolosky added a commit to HowardWolosky/PowerShellForGitHub that referenced this issue Jun 5, 2019
@HowardWolosky
Add diagnostic data dll names to .gitignore
930084b 
These dll's are used for reporting diagnostic data and users can
optionally store them in the module's directory to avoid downloading
them on demand (or they can use Set-GitHubConfiguration -AssemblyPath
to specify an alternate location).

For users that opt to put the dll's in the module directory and are using
the module from a git enlistment, this will ignore those files.

This should be temporary and should be able to be undone once microsoft#104 is resolved.
@HowardWolosky HowardWolosky mentioned this issue Jun 5, 2019
Merged
HowardWolosky added a commit that referenced this issue Jun 5, 2019
@HowardWolosky
Add diagnostic data dll names to .gitignore (#113)
8cf6821 
These dll's are used for reporting diagnostic data and users can
optionally store them in the module's directory to avoid downloading
them on demand (or they can use Set-GitHubConfiguration -AssemblyPath
to specify an alternate location).

For users that opt to put the dll's in the module directory and are using
the module from a git enlistment, this will ignore those files.

This should be temporary and should be able to be undone once #104 is resolved.
@HowardWolosky HowardWolosky added in progress Work on this issue is already underway. Please don't work start new work on it. and removed good first issue If you're new to the project (or to OSS in general) and you'd like to contribute, try this one. help wanted Anyone in the community is welcome to do this work up for grabs Anyone in the community is welcome to do this work labels Jun 1, 2020
@HowardWolosky HowardWolosky mentioned this issue Jun 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HowardWolosky HowardWolosky

Labels
enhancement An issue or pull request introducing new functionality to the project. in progress Work on this issue is already underway. Please don't work start new work on it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing binary dependencies for telemetry HowardWolosky/PowerShellForGitHub
1 participant
@HowardWolosky