Fix static analysis misses with new Fork featurework

microsoft · Nov 13, 2018 · 5703295 · 5703295
1 parent 1076239
commit 5703295
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,21 +1,33 @@
 # PowerShellForGitHub PowerShell Module
 ## Changelog
 
-## [0.0.2](https://github.com/PowerShell/PowerShellForGitHub/tree/0.3.0) - (2018/11/13)
+## [0.3.1](https://github.com/PowerShell/PowerShellForGitHub/tree/0.3.1) - (2018/11/13)
+### Fixes:
+* Minor static analysis issues fixed.
+* Corrected name of the test file for `GitHubRepositoryForks`
+* Ensured the `getParams` are used during execution of `Get-GitHubRepositoryFork`
+
+More Info: [[pr]](https://github.com/PowerShell/PowerShellForGitHub/pull/42) | [[cl]](https://github.com/PowerShell/PowerHellForGitHub/commit/TODO)
+
+Author: [**@HowardWolosky**](https://github.com/HowardWolosky)
+
+------
+
+## [0.3.0](https://github.com/PowerShell/PowerShellForGitHub/tree/0.3.0) - (2018/11/13)
 ### Features:
 + Added support for querying forks and creating new ones.
 
 ### Fixes:
 * Will only perform a retry when receiving a `202` response on a `GET` request.  Previously, it would
   retry regardless of the method of the request.
 
-More Info: [[pr]](https://github.com/PowerShell/PowerShellForGitHub/pull/41) | [[cl]](https://github.com/PowerShell/PowerHellForGitHub/commit/TODO)
+More Info: [[pr]](https://github.com/PowerShell/PowerShellForGitHub/pull/41) | [[cl]](https://github.com/PowerShell/PowerHellForGitHub/commit/1076239d7639497984a6e0b04df1e69019c4ec28)
 
 Author: [**@HowardWolosky**](https://github.com/HowardWolosky)
 
 ------
 
-## [0.0.2](https://github.com/PowerShell/PowerShellForGitHub/tree/0.2.0) - (2018/11/13)
+## [0.2.0](https://github.com/PowerShell/PowerShellForGitHub/tree/0.2.0) - (2018/11/13)
 ### Features:
 + Significant restructing and refactoring of entire module to make future expansion easier.
 + Significant documentation updates ([CHANGELOG](./CHANGELOG.md), [CONTRIBUTING.md](./CONTRIBUTING.md),

diff --git a/GitHubRepositoryForks.ps1 b/GitHubRepositoryForks.ps1
@@ -84,7 +84,7 @@ function Get-GitHubRepositoryFork
     )
 
     $params = @{
-        'UriFragment' = "repos/$OwnerName/$RepositoryName/forks"
+        'UriFragment' = "repos/$OwnerName/$RepositoryName/forks`?" +  ($getParams -join '&')
         'Description' =  "Getting all forks of $RepositoryName"
         'AccessToken' = $AccessToken
         'TelemetryEventName' = $MyInvocation.MyCommand.Name

diff --git a/Tests/GitHubRepositoryForks.ps1 → Tests/GitHubRepositoryForks.tests.ps1 b/Tests/GitHubRepositoryForks.ps1 → Tests/GitHubRepositoryForks.tests.ps1
@@ -88,7 +88,7 @@ Describe 'Creating a new fork for user' {
             $newForks[0].full_name | Should be "$($script:ownerName)/PowerShellForGitHub"
         }
 
-        Remove-GitHubRepository -OwnerName $script:ownerName -RepositoryName PowerShellForGitHub
+        Remove-GitHubRepository -Uri $repo.svn_url
     }
 }
 
@@ -107,7 +107,7 @@ Describe 'Creating a new fork for an org' {
             $newForks[0].full_name | Should be "$($script:organizationName)/PowerShellForGitHub"
         }
 
-        Remove-GitHubRepository -OwnerName $script:organizationName -RepositoryName PowerShellForGitHub
+        Remove-GitHubRepository -Uri $repo.svn_url
     }
 }