Add analysis progress reporting to LS #4483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 3, 2018 17:42
zooba
approved these changes
Jul 5, 2018
|
|
||
| Analyzer.EnableDiagnostics = _clientCaps?.python?.liveLinting ?? false; |
There was a problem hiding this comment.
This property should go away in favour of suppressing the individual messages (probably by default, at least for the ones currently hidden by this flag)
There was a problem hiding this comment.
Yep. We should discuss messages, error codes, etc.
| @@ -14,7 +14,7 @@ | |||
| // See the Apache Version 2.0 License for specific language governing | |||
| // permissions and limitations under the License. | |||
|
|
|||
| // #define WAIT_FOR_DEBUGGER | |||
| #define WAIT_FOR_DEBUGGER | |||
There was a problem hiding this comment.
Guessing you don't mean to check this in?
added 2 commits
July 5, 2018 15:38
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PVSC: microsoft/vscode-python#2099