Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Updating CodeQL configuration #498

Merged
merged 5 commits into from
May 17, 2024
Merged

Conversation

muiriswoulfe
Copy link
Member

@muiriswoulfe muiriswoulfe commented May 15, 2024

Summary

This change primarily improves the clarity of the pull request template and reorganizes the CodeQL validation workflow, moving this from the build.yml workflow to a new codeql.yml workflow.

Simplification of Pull Request Template:

  • .github/pull_request_template.md: The pull request template was simplified by removing the separate "Motivation" and "Technical" sections and replacing them with a single comment instructing users to provide a summary of the reasons or motivations behind the PR, what it aims to accomplish, and technical implementation details.

Reorganization of CodeQL Validation Workflow:

  • .github/workflows/build.yml: The "validate-codeql" job was removed from this workflow.
  • .github/workflows/codeql.yml: A new workflow file was created for the CodeQL validation job. This job is set to run on push and pull request events for the main branch, on a weekly schedule, and on workflow dispatch events. The job includes steps to checkout the code, initialize CodeQL, and analyze the code.

@muiriswoulfe muiriswoulfe requested a review from a team as a code owner May 15, 2024 17:55
Copy link
Contributor

github-actions bot commented May 15, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 60
Total 60

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Updating CodeQL coniguration XS✔ ◾ Updating CodeQL coniguration May 15, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@muiriswoulfe muiriswoulfe changed the title XS✔ ◾ Updating CodeQL coniguration XS✔ ◾ Updating CodeQL configuration May 15, 2024
@muiriswoulfe muiriswoulfe self-assigned this May 16, 2024
@muiriswoulfe muiriswoulfe added bug Something isn't working enhancement New feature or request labels May 16, 2024
@muiriswoulfe muiriswoulfe merged commit d4889db into main May 17, 2024
17 checks passed
@muiriswoulfe muiriswoulfe deleted the muiriswoulfe/codeql branch May 17, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants