Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Fixing build task "Validate .markdownlint.json" #455

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

muiriswoulfe
Copy link
Member

Summary

Motivation

The build has started to fail on the task "Validate .markdownlint.json".

Technical

The issue has been fixed by passing strict: false to the JSON validation task. This is now required because https://raw.githubusercontent.com/DavidAnson/markdownlint/main/schema/markdownlint-config-schema.json was recently updated to add an $id element, which is unsupported by the walbo/validate-json action.

Testing

Test Types

  • Unit tests
  • Manual tests

Unit Test Coverage

100%

@muiriswoulfe muiriswoulfe added the bug Something isn't working label Jan 15, 2024
@muiriswoulfe muiriswoulfe self-assigned this Jan 15, 2024
@muiriswoulfe muiriswoulfe requested a review from a team as a code owner January 15, 2024 11:24
Copy link
Contributor

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 1
Total 1

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Fixing build task "Validate .markdownlint.json" XS✔ ◾ Fixing build task "Validate .markdownlint.json" Jan 15, 2024
@muiriswoulfe muiriswoulfe enabled auto-merge (squash) January 15, 2024 11:40
@muiriswoulfe muiriswoulfe merged commit 63e7442 into main Jan 15, 2024
18 checks passed
@muiriswoulfe muiriswoulfe deleted the muiriswoulfe/lint-fix-markdownlintschemajson branch January 15, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants