Show dashes (-) instead of 0 in the table (#443)

## Summary ### Motivation Show dashes (-) instead of 0 in the table ## Testing ### Test Types - [x] Unit tests - [ ] Manual tests
microsoft · Dec 12, 2023 · 672351a · 672351a
1 parent ccdcdf4
commit 672351a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/src/task/src/pullRequests/pullRequestComments.ts b/src/task/src/pullRequests/pullRequestComments.ts
@@ -202,6 +202,11 @@ export default class PullRequestComments {
       surround = '**'
     }
 
-    return `${surround}${title}${surround}|${surround}${metric.toLocaleString()}${surround}\n`
+    let metricString = metric.toLocaleString()
+    if (metricString === '0') {
+      metricString = '-'
+    }
+
+    return `${surround}${title}${surround}|${surround}${metricString}${surround}\n`
   }
 }
diff --git a/src/task/tests/pullRequests/pullRequestComments.spec.ts b/src/task/tests/pullRequests/pullRequestComments.spec.ts
@@ -359,11 +359,11 @@ describe('pullRequestComments.ts', (): void => {
             '✔ **Thanks for adding tests.**\n' +
             '||Lines\n' +
             '-|-:\n' +
-            `Product Code|${code[0].toLocaleString()}\n` +
-            `Test Code|${code[1].toLocaleString()}\n` +
-            `**Subtotal**|**${code[2].toLocaleString()}**\n` +
-            `Ignored Code|${code[3].toLocaleString()}\n` +
-            `**Total**|**${code[4].toLocaleString()}**\n` +
+            `Product Code|${code[0].toLocaleString() === '0' ? '-' : code[0].toLocaleString()}\n` +
+            `Test Code|${code[1].toLocaleString() === '0' ? '-' : code[1].toLocaleString()}\n` +
+            `**Subtotal**|**${code[2].toLocaleString() === '0' ? '-' : code[2].toLocaleString()}**\n` +
+            `Ignored Code|${code[3].toLocaleString() === '0' ? '-' : code[3].toLocaleString()}\n` +
+            `**Total**|**${code[4].toLocaleString() === '0' ? '-' : code[4].toLocaleString()}**\n` +
             '\n' +
             '[Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!](https://aka.ms/PRMetrics/Comment)')
           verify(logger.logDebug('* PullRequestComments.getMetricsComment()')).once()