Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Speed up tests #99

Merged
merged 8 commits into from
Apr 9, 2021
Merged

Speed up tests #99

merged 8 commits into from
Apr 9, 2021

Conversation

alfredclwong
Copy link
Collaborator

@alfredclwong alfredclwong commented Apr 8, 2021

Would still like to use XUnit.jl to parallelise tests, but the improvements here are already good enough to merit a PR.

Fixes #54

@codecov-io
Copy link

codecov-io commented Apr 8, 2021

Codecov Report

Merging #99 (6000097) into main (23e0376) will decrease coverage by 1.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   47.61%   46.45%   -1.16%     
==========================================
  Files          57       56       -1     
  Lines        6620     6578      -42     
==========================================
- Hits         3152     3056      -96     
- Misses       3468     3522      +54     
Impacted Files Coverage Δ
src/Geometry/Primitives/Curves/BSpline.jl 66.15% <0.00%> (-11.71%) ⬇️
src/Geometry/Primitives/Qtype.jl 75.00% <0.00%> (-8.34%) ⬇️
src/Optical/LensAssembly.jl 48.22% <0.00%> (-7.33%) ⬇️
src/Optical/OpticalInterface.jl 62.68% <0.00%> (-4.42%) ⬇️
src/Geometry/CSG/Intersection.jl 48.57% <0.00%> (-2.14%) ⬇️
src/Geometry/Geometry.jl 0.00% <0.00%> (-1.86%) ⬇️
src/Geometry/Primitives/Curves/Bezier.jl 54.87% <0.00%> (-1.83%) ⬇️
src/Geometry/CSG/Interval.jl 83.20% <0.00%> (-0.37%) ⬇️
src/Optical/OpticalSystem.jl 35.89% <0.00%> (-0.33%) ⬇️
src/Geometry/CSG/CSG.jl 84.88% <0.00%> (-0.06%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e0376...6000097. Read the comment docs.

@alfredclwong alfredclwong requested review from BrianGun and friggog April 8, 2021 18:34
@alfredclwong alfredclwong enabled auto-merge (squash) April 8, 2021 18:34
@BrianGun
Copy link
Contributor

BrianGun commented Apr 8, 2021

@alfredclwong Looked at the code more closely. Allocations tests are still being run. I'll approve as soon as the checks finish.

@alfredclwong
Copy link
Collaborator Author

Agreed - the Allocations testset is very important. It is included in alltestsets:

"Allocations",

@alfredclwong
Copy link
Collaborator Author

alfredclwong commented Apr 8, 2021

1.5 is failing for some reason. Will look into this tmrw.

@alfredclwong
Copy link
Collaborator Author

Caching all of .julia runs us into some weird problems, so I'll just stick with .julia/artifacts. There's probably a good reason why everyone does it this way.

@alfredclwong alfredclwong disabled auto-merge April 9, 2021 09:33
@alfredclwong alfredclwong enabled auto-merge (squash) April 9, 2021 09:34
@alfredclwong alfredclwong merged commit 6253fba into main Apr 9, 2021
@alfredclwong alfredclwong deleted the speedup-tests branch April 9, 2021 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up slow tests
3 participants