Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Fix sources #96

Merged
merged 4 commits into from
Apr 8, 2021
Merged

Fix sources #96

merged 4 commits into from
Apr 8, 2021

Conversation

alfredclwong
Copy link
Collaborator

  1. NIKON link changed
  2. HOYA website (hoyaoptics.com) is down. New link found - @BrianGun could you verify that this link is OK? Added support in build script for direct AGF downloads (previously only supported ZIP archives).
  3. Sumita link changed. @BrianGun there's a download option for discontinued glasses - do we want this?

Also extended ZIP file support to automatically pick the first AGF file in the downloaded ZIP archive.

@alfredclwong alfredclwong requested a review from BrianGun April 8, 2021 11:55
@alfredclwong alfredclwong enabled auto-merge (squash) April 8, 2021 11:56
@codecov-io
Copy link

Codecov Report

Merging #96 (6dfe488) into main (103c70f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files          57       57           
  Lines        6620     6620           
=======================================
  Hits         3152     3152           
  Misses       3468     3468           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103c70f...6dfe488. Read the comment docs.

@alfredclwong alfredclwong merged commit a76a75e into main Apr 8, 2021
@alfredclwong alfredclwong deleted the fix-sources branch April 8, 2021 18:45
@BrianGun
Copy link
Contributor

BrianGun commented Apr 8, 2021

Don't think we want to include discontinued Sumita glasses, or other manufacturers, in the default download. Let users get them in a separate step if they need them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants