Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Remove unused Emitter2.jl file #88

Closed
wants to merge 1 commit into from
Closed

Remove unused Emitter2.jl file #88

wants to merge 1 commit into from

Conversation

BrianGun
Copy link
Contributor

@BrianGun BrianGun commented Apr 7, 2021

Pull Request Template

Description

Emitter2.jl is old code not used anywhere. Removing it from the project.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

No tests required since the code is unused.

  • Test A
  • Test B

Test Configuration(s):

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@alfredclwong
Copy link
Collaborator

I'm already addressing this in PR #83, commit abdd925. There's also an include statement in Optical.jl that needs to be removed. Probably not worth making another PR just for this.

@alfredclwong alfredclwong deleted the BrianGun/issue87 branch April 7, 2021 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants