This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
Adding Pluto and Some sample notebooks #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: WGLMakie can clash with GLMAkie - we need to maybe create an init function to resolve it once and for all. Added the NotebooksUtils module to help repeating notebook code. Added 2 utility functions to the Vis module to allow better control of rendering inside Pluto notebooks. added 3 sample notebooks in the samples/notebooks folder and a utility function to launch Pluto and run them. added a small description in the documentation Examples page instructing how to launch the notebooks. added a call to the GLMakie.activate!() function in the documentation script to make sure the GLMakie backend is used. Bug Fix: Seems like i forgot to include the new emitters page in the make.jl script that produce the documentation pages.
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
==========================================
- Coverage 48.64% 46.79% -1.85%
==========================================
Files 56 56
Lines 6474 6569 +95
==========================================
- Hits 3149 3074 -75
- Misses 3325 3495 +170
Continue to review full report at Codecov.
|
|
@alfredclwong @BrianGun |
…eep to make it the makie default backend after adding WGLMakie to the package. fixed small issues with the samples notebooks.
BrianGun
approved these changes
Apr 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focus on adding Pluto and the some Pluto notebooks to the package.
added dependency on new packages: Pluto, PlutoUI, WGLMakie, Format
Note: WGLMakie can clash with GLMAkie - we need to maybe create an init function to resolve it once and for all.
Added the NotebooksUtils module to help repeating notebook code.
Added 2 utility functions to the Vis module to allow better control of rendering inside Pluto notebooks.
added 3 sample notebooks in the samples/notebooks folder and a utility function to launch Pluto and run them.
added a small description in the documentation Examples page instructing how to launch the notebooks.
added a call to the GLMakie.activate!() function in the documentation script to make sure the GLMakie backend is used.
Bug Fix: Seems like i forgot to include the new emitters page in the make.jl script that produce the documentation pages.