-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
- Coverage 49.01% 47.75% -1.26%
==========================================
Files 55 55
Lines 6425 6431 +6
==========================================
- Hits 3149 3071 -78
- Misses 3276 3360 +84
Continue to review full report at Codecov.
|
7867d51
to
d8a6d4a
Compare
re outputs: I was thinking of writing some kind of "Ray Database" type, similar to a .ZRD file in Zemax, maybe next week. Any other thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@friggog do you have a simple example you could add to the Examples directory? Maybe a call to traceMT which returns an image? Since any example would need an Azure account to bill against that part could be left for the user to fill in, perhaps with inline comments that explain what the user needs to do to make it work. And maybe a paragraph of documentation in the docs? You could add a new section, Cloud Computation, or something like that. Otherwise people are going to have a hard time figuring out how to use this.
@friggog were you going to add an example and some documentation? It will be confusing to new users otherwise. |
Yeah there are a few things to do still (see list on top comment here) hopefully will get around to it this week but will see how busy I am |
@alfredclwong can I preview built docs from this branch somehow? |
@friggog deploydocs has an argument that'll push PR previews to the gh-pages branch. i've pushed a commit that'll try out that feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to do this. I don't think I have the permissions yet to try it out, but I assume you've tested it yourself.
Are there any other features related to this that we should work on after this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 lines need changing - I'll push the changes in a sec
yeah it seems to be working for a simple test script. The pycall setup is the most dodgy bit so maybe need some refinement there, seems to be very dependent on local environment (ie conda/python install) I might be able to give you permissions though I just removed my ownership so we might need Ran or Brian to do that now |
8ebc8d3
to
390366b
Compare
Adds support for running simulations on AML, addressing #40
TODO:
No sysimage - docker has packages built/precompiled when using OpticSim as a dependency which is probably sufficientWe could call julia directly using ScriptRunConfig "command" rather than having the entry script stuff, I think we'll always need to resolve the environment first though and it becomes a pain to configure thread count.