Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

AML cloud support #71

Merged
merged 11 commits into from
Apr 7, 2021
Merged

AML cloud support #71

merged 11 commits into from
Apr 7, 2021

Conversation

friggog
Copy link
Collaborator

@friggog friggog commented Apr 1, 2021

Adds support for running simulations on AML, addressing #40

TODO:

  • Needs #69 for this to work when running from a clone of the repo
  • Hyperdrive not currently supported
  • Figure out outputs - what is the typical output we want/how do we transfer back from AML?
  • No sysimage - docker has packages built/precompiled when using OpticSim as a dependency which is probably sufficient
  • Add docs

We could call julia directly using ScriptRunConfig "command" rather than having the entry script stuff, I think we'll always need to resolve the environment first though and it becomes a pain to configure thread count.

@friggog friggog changed the title [WIP] AML cloud support initial [WIP] AML cloud support Apr 1, 2021
@codecov-io
Copy link

codecov-io commented Apr 1, 2021

Codecov Report

Merging #71 (d6ae5fa) into main (ec7d3c1) will decrease coverage by 1.25%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   49.01%   47.75%   -1.26%     
==========================================
  Files          55       55              
  Lines        6425     6431       +6     
==========================================
- Hits         3149     3071      -78     
- Misses       3276     3360      +84     
Impacted Files Coverage Δ
src/Cloud/Cloud.jl 0.00% <0.00%> (ø)
src/OpticSim.jl 83.33% <ø> (ø)
src/Optimization/Optimization.jl 0.00% <ø> (ø)
src/Geometry/Primitives/Qtype.jl 75.00% <0.00%> (-8.34%) ⬇️
src/Optical/LensAssembly.jl 48.22% <0.00%> (-7.33%) ⬇️
src/Optical/OpticalInterface.jl 62.68% <0.00%> (-4.42%) ⬇️
src/Geometry/CSG/Intersection.jl 48.57% <0.00%> (-2.14%) ⬇️
src/Geometry/Geometry.jl 0.00% <0.00%> (-1.86%) ⬇️
src/Geometry/CSG/Interval.jl 83.20% <0.00%> (-0.37%) ⬇️
src/Geometry/Primitives/Curves/BSpline.jl 77.51% <0.00%> (-0.35%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7d3c1...d6ae5fa. Read the comment docs.

@alfredclwong
Copy link
Collaborator

re outputs: I was thinking of writing some kind of "Ray Database" type, similar to a .ZRD file in Zemax, maybe next week. Any other thoughts?

Copy link
Contributor

@BrianGun BrianGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@friggog do you have a simple example you could add to the Examples directory? Maybe a call to traceMT which returns an image? Since any example would need an Azure account to bill against that part could be left for the user to fill in, perhaps with inline comments that explain what the user needs to do to make it work. And maybe a paragraph of documentation in the docs? You could add a new section, Cloud Computation, or something like that. Otherwise people are going to have a hard time figuring out how to use this.

@BrianGun
Copy link
Contributor

BrianGun commented Apr 5, 2021

@friggog were you going to add an example and some documentation? It will be confusing to new users otherwise.

@friggog
Copy link
Collaborator Author

friggog commented Apr 5, 2021

Yeah there are a few things to do still (see list on top comment here) hopefully will get around to it this week but will see how busy I am

@BrianGun
Copy link
Contributor

BrianGun commented Apr 5, 2021 via email

@friggog friggog changed the title [WIP] AML cloud support AML cloud support Apr 7, 2021
@friggog
Copy link
Collaborator Author

friggog commented Apr 7, 2021

@alfredclwong can I preview built docs from this branch somehow?

@friggog friggog requested a review from alfredclwong April 7, 2021 16:19
@alfredclwong
Copy link
Collaborator

@friggog deploydocs has an argument that'll push PR previews to the gh-pages branch. i've pushed a commit that'll try out that feature.

Copy link
Collaborator

@alfredclwong alfredclwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to do this. I don't think I have the permissions yet to try it out, but I assume you've tested it yourself.

Are there any other features related to this that we should work on after this PR?

Copy link
Collaborator

@alfredclwong alfredclwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 lines need changing - I'll push the changes in a sec

docs/src/cloud.md Outdated Show resolved Hide resolved
@friggog
Copy link
Collaborator Author

friggog commented Apr 7, 2021

Thanks for taking the time to do this. I don't think I have the permissions yet to try it out, but I assume you've tested it yourself.

yeah it seems to be working for a simple test script. The pycall setup is the most dodgy bit so maybe need some refinement there, seems to be very dependent on local environment (ie conda/python install)

I might be able to give you permissions though I just removed my ownership so we might need Ran or Brian to do that now

@alfredclwong alfredclwong merged commit ff8b93d into main Apr 7, 2021
@alfredclwong alfredclwong deleted the user/chewitt/aml branch April 7, 2021 19:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants